From: annie li <annie.li@oracle.com>
To: Wei Liu <liuw@liuw.name>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
David Vrabel <david.vrabel@citrix.com>,
jbeulich@suse.com
Subject: Re: [Xen-devel] [PATCH net-next V3 2/3] xen-netfront: split event channels support for Xen frontend driver
Date: Wed, 22 May 2013 16:35:14 -0400 [thread overview]
Message-ID: <519D2C02.7080500@oracle.com> (raw)
In-Reply-To: <CAOsiSVXptBRRA=m3HFnO7eQWjxN_wgfzAcvw+rPebOPH9mRjXg@mail.gmail.com>
On 2013-5-22 16:20, Wei Liu wrote:
> On Wed, May 22, 2013 at 8:32 PM, annie li <annie.li@oracle.com> wrote:
>>
>> Originally, netfront protects access to rx shared-ring with tx_lock, you
>> remove this protection here. It is better to protect the ring access by a
>> sperate rx_lock then.
>>
> TX ring and RX ring are separate rings. I don't think that comment / code
> makes sense any more. My stress test confirms that.
Yes, they are separate rings. Actually I am not sure why
RING_HAS_UNCONSUMED_RESPONSES(&np->rx) is protected by any tx_lock
originally. But for xennet_rx_interrupt, it is better to use rx_lock to
protect RING_HAS_UNCONSUMED_RESPONSES(&np->rx).
Thanks
Annie
>
>
> Wei.
>
>> Thanks
>> Annie
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-05-22 20:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 16:34 [PATCH net-next 0/2 V3] Xen network: split event channels support Wei Liu
2013-05-22 16:34 ` [PATCH net-next V3 1/3] xen-netback: split event channels support for Xen backend driver Wei Liu
2013-06-24 9:48 ` Jan Beulich
2013-06-24 10:18 ` Wei Liu
2013-05-22 16:34 ` [PATCH net-next V3 2/3] xen-netfront: split event channels support for Xen frontend driver Wei Liu
2013-05-22 19:32 ` annie li
2013-05-22 20:20 ` [Xen-devel] " Wei Liu
2013-05-22 20:35 ` annie li [this message]
2013-05-22 20:38 ` Wei Liu
2013-05-23 13:46 ` Wei Liu
2013-05-23 14:14 ` annie li
2013-05-22 16:34 ` [PATCH net-next V3 3/3] xen: netif.h: document feature-split-event-channels Wei Liu
2013-05-24 1:41 ` [PATCH net-next 0/2 V3] Xen network: split event channels support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D2C02.7080500@oracle.com \
--to=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=liuw@liuw.name \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).