From: dingtianhong <dingtianhong@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Netdev <netdev@vger.kernel.org>, Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister
Date: Thu, 23 May 2013 09:43:46 +0800 [thread overview]
Message-ID: <519D7452.8050405@huawei.com> (raw)
In-Reply-To: <519D0EBB.4030307@cogentembedded.com>
On 2013/5/23 2:30, Sergei Shtylyov wrote:
> Hello.
>
> On 22-05-2013 12:42, dingtianhong wrote:
>
>> commit 00cfec3748 (net: add a synchronize_net() ...) add a synchronize_net()
>
> Please specify complete summary line of this commit.
>
ok, I will modify and send again, just tell me your opinion, thanks.
>> in netdev_rx_handler_unregister() to guarantee the rx_handler is NULL when
>> rx_handler_data is a non NULL in rcu_read_lock().
>>
>> so the caller should not use netdev_rx_handler_unregister in atomic as it may
>> schedule and sleep, the commit fcd99434f
>
> You forgot to specify the summary line of this commit.
>
>> fix the bug in bond release, but the
>> problem is no action to guarantee the rx_handler_data is NULL when bond release,
>> so add synchronize_net() and fix it.
>
>> This patch adds more comments to netdev_rx_handler_unregister().
>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>
> WBR, Sergei
>
>
>
next prev parent reply other threads:[~2013-05-23 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 8:42 [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister dingtianhong
2013-05-22 11:45 ` Eric Dumazet
2013-05-23 1:41 ` dingtianhong
2013-05-23 1:52 ` Eric Dumazet
2013-05-23 7:50 ` dingtianhong
2013-05-22 18:30 ` Sergei Shtylyov
2013-05-23 1:43 ` dingtianhong [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-23 1:57 dingtianhong
2013-05-23 2:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D7452.8050405@huawei.com \
--to=dingtianhong@huawei.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fubar@us.ibm.com \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).