From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DA2C10F14 for ; Mon, 15 Apr 2019 02:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A123120848 for ; Mon, 15 Apr 2019 02:24:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sMRh2npI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726533AbfDOCY2 (ORCPT ); Sun, 14 Apr 2019 22:24:28 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:39479 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfDOCY2 (ORCPT ); Sun, 14 Apr 2019 22:24:28 -0400 Received: by mail-io1-f65.google.com with SMTP id e13so13304292ioq.6 for ; Sun, 14 Apr 2019 19:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/INP0SgplHmchvDAbzmQ8QvaLUZmMaSBDSRPqvwMVvI=; b=sMRh2npI5HDz17ZUVS+pGxvC1VaUjAAAZZrCtFN/Z3eQVDhLaViBNB05iY5MezpZhn J+W8sT/252ei4mBt/MMW6AMEAkTYvwqUC2FpyTFCAyXcM9zQu9LPXwP77HtrefpweavT 7YwimQkvLa/Oe+bZLezqxGxWrX0V6cigpF+l/Z2Zqj6EWB4VYJ2OYhvQc/guNGAUF7n4 us/Tc7l4YpjtngO808ATefEsT/ygQJd7APBAjXaIG9BixOPOblklqIb+a7TPIfqpy0p2 Pbt4hoPGaQN4tokS6StqnBfYhTO8M9UrK6odf7ia2NUfGNbJW2WtB/AnONnxUajm+bqb ZkkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/INP0SgplHmchvDAbzmQ8QvaLUZmMaSBDSRPqvwMVvI=; b=nXd9lnoz3aHblQXxtDvY2lOGAtAa4itJ609CHsDiIirAFPMxTuh8wxTJ27k6XbA/TM 8OEa1AzV4jfzZ3Ka41tgf+I0u7onBaLu85EWpZCLDO9hp5qQO15jM7FOU27/omJAo6aW jkaKQKUwP/0qs3vrgz81Jw57A1pU0Z+qly89sh69l/6F0GabxD1w3ZXGouMmPzLA3PXV IsznVc0dLye67aAHW1lQPRWKYN4shsNTRGRT7Okj8uKrThm2yLOYkmv5HNxR5y8MF0CY e5KgVJ/iReMMRF7art9NuUmgYL1UlPZB98w4oZPBZgVdORwgn+Yjo27mMZqyDGk6LPwh RWYw== X-Gm-Message-State: APjAAAWlnKJdX2XYSF8OvO2LVHhQlNo0JBXqzAiSlqSpSvOvwiNen5yv DYo3qe2GjcAL8SDGUpUcxpY= X-Google-Smtp-Source: APXvYqwSHDXZl/PxowGyguAC226CrHnCUHS3qSwTBPkpaitUNcXcdlFkbKX40Tn/R4r+F5AephUhbg== X-Received: by 2002:a6b:7b08:: with SMTP id l8mr44439561iop.33.1555295067506; Sun, 14 Apr 2019 19:24:27 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:5525:5fcf:c7fd:1148? ([2601:282:800:fd80:5525:5fcf:c7fd:1148]) by smtp.googlemail.com with ESMTPSA id b15sm18815587ios.25.2019.04.14.19.24.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2019 19:24:26 -0700 (PDT) Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, jakub.kicinski@netronome.com References: <20190413162112.8203-1-jiri@resnulli.us> <20190413162112.8203-3-jiri@resnulli.us> From: David Ahern Message-ID: <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com> Date: Sun, 14 Apr 2019 20:24:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190413162112.8203-3-jiri@resnulli.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/13/19 10:20 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently there is one devlink instance created per network namespace. > That is quite odd considering the fact that devlink instance should > represent an ASIC. The following patches are going to move the devlink > instance even more down to a bus device, but until then, have one > devlink instance per netdevsim instance. Struct nsim_devlink is > introduced to hold fib setting. > > Signed-off-by: Jiri Pirko > --- > drivers/net/netdevsim/devlink.c | 179 +++++++++++------------------- > drivers/net/netdevsim/fib.c | 103 +++++++---------- > drivers/net/netdevsim/netdev.c | 27 ++--- > drivers/net/netdevsim/netdevsim.h | 18 +-- > 4 files changed, 125 insertions(+), 202 deletions(-) you are making a lot of changes to how fib events are handled and not explaining what you are doing.