Re: [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support

[Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>]

On 5/26/2013 12:12 PM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
> Date: Thu, 23 May 2013 18:00:23 +0530
>
>> From: Hebbar Gururaja <gururaja.hebbar-l0cyMroinI0@public.gmane.org>
>>
>> Amend cpsw controller to optionally take a pin control handle and set
>> the state of the pins to:
>>
>> - "default" on boot, resume
>> - "sleep" on suspend()
>>
>> This should make it possible to optimize energy usage for the pins
>> for the suspend/resume cycle.
>>
>> If any of the above pin states are missing in dt, a warning message
>> about the missing state is displayed.
>> If certain pin-states are not available, to remove this warning message
>> pass respective state name with null phandler.
>>
>> Signed-off-by: Hebbar Gururaja <gururaja.hebbar-l0cyMroinI0@public.gmane.org>
>> Signed-off-by: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
> This still needs some work:
>
>> +		/*
>> +		* Since we continue even when pinctrl node is not found,
>> +		* Invalidate pins as not available. This is to make sure that
>> +		* IS_ERR(pins_xxx) results in failure when used.
>> +		*/
> The second, third, fourth, and fifth lines are not tabbed correctly.  They
> should all be two TABs and a SPACE.
>
> Secondly, comments in the networking are to be formatted:
>
> 	/* Like
> 	 * this.
> 	 */
Will fix this and will resubmit the next version today.

Regards
Mugunthan V N