From: Rik van Riel <riel@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Rafael Aquini <aquini@redhat.com>,
Ben Greear <greearb@candelatech.com>,
Francois Romieu <romieu@fr.zoreil.com>,
atomlin@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, pshelar@nicira.com, mst@redhat.com,
alexander.h.duyck@intel.com, sergei.shtylyov@cogentembedded.com,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets
Date: Tue, 28 May 2013 17:32:07 -0400 [thread overview]
Message-ID: <51A52257.4060905@redhat.com> (raw)
In-Reply-To: <1369758577.3301.543.camel@edumazet-glaptop>
On 05/28/2013 12:29 PM, Eric Dumazet wrote:
> On Tue, 2013-05-28 at 13:15 -0300, Rafael Aquini wrote:
>
>> The real problem seems to be that more and more the network stack (drivers, perhaps)
>> is relying on chunks of contiguous page-blocks without a fallback mechanism to
>> order-0 page allocations. When memory gets fragmented, these alloc failures
>> start to pop up more often and they scare ordinary sysadmins out of their paints.
>>
>
> Where do you see that ?
>
> I see exactly the opposite trend.
>
> We have less and less buggy drivers, and we want to catch last
> offenders.
These backtraces would still get printed out for drivers
that DO do the right thing and fall back to smaller
allocations.
The initial failed large allocation would cause a backtrace.
next prev parent reply other threads:[~2013-05-28 21:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:45 [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets atomlin
2013-05-27 18:18 ` Rafael Aquini
2013-05-27 22:41 ` Francois Romieu
2013-05-28 16:00 ` Ben Greear
2013-05-28 16:15 ` Rafael Aquini
2013-05-28 16:19 ` Ben Greear
2013-05-28 16:29 ` Eric Dumazet
2013-05-28 17:43 ` Rafael Aquini
2013-05-28 17:46 ` Eric Dumazet
2013-05-28 18:03 ` Eric Dumazet
2013-05-28 18:19 ` Joe Perches
2013-05-28 21:32 ` Rik van Riel [this message]
2013-05-28 17:29 ` Joe Perches
2013-05-28 21:30 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2013-05-26 20:19 atomlin
2013-05-27 17:39 ` Rik van Riel
2013-05-27 22:25 ` Eric Dumazet
2013-05-28 4:31 ` Joe Perches
2013-05-28 6:04 ` Eric Dumazet
2013-05-28 6:08 ` Joe Perches
2013-05-28 17:15 ` Debabrata Banerjee
2013-05-29 7:36 ` Rik van Riel
2013-05-27 17:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A52257.4060905@redhat.com \
--to=riel@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=aquini@redhat.com \
--cc=atomlin@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).