From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eliezer Tamir Subject: Re: [PATCH v6 net-next 1/5] net: add napi_id and hash Date: Wed, 29 May 2013 18:04:19 +0300 Message-ID: <51A618F3.7050407@linux.intel.com> References: <20130529063916.27486.3841.stgit@ladj378.jer.intel.com> <20130529063925.27486.46649.stgit@ladj378.jer.intel.com> <1369832201.5109.8.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jesse Brandeburg , Don Skidmore , e1000-devel@lists.sourceforge.net, Willem de Bruijn , Andi Kleen , HPA , Eilon Greenstien , Or Gerlitz , Alex Rosenbaum , Eliezer Tamir To: Eric Dumazet Return-path: In-Reply-To: <1369832201.5109.8.camel@edumazet-glaptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 29/05/2013 15:56, Eric Dumazet wrote: > On Wed, 2013-05-29 at 09:39 +0300, Eliezer Tamir wrote: >> Adds a napi_id and a hashing mechanism to lookup a napi by id. >> This will be used by subsequent patches to implement low latency >> Ethernet device polling. >> Based on a code sample by Eric Dumazet. >> >> Signed-off-by: Eliezer Tamir >> --- > > OK this looks good enough for inclusion. > > If a v7 ever is submitted, please add a 'static' for > > static DEFINE_SPINLOCK(napi_hash_lock); > static unsigned int napi_gen_id; > static DEFINE_HASHTABLE(napi_hash, 8); > I will post a v7 along with the changes you suggested to 2/5, I will wait a bit to see if there are other things to fix. Thanks, Eliezer