From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next rfc V2 6/8] macvtap: allow TUNSETIFF to create multiqueue device Date: Fri, 31 May 2013 18:48:09 +0400 Message-ID: <51A8B829.7040708@cogentembedded.com> References: <1369994005-5943-1-git-send-email-jasowang@redhat.com> <1369994005-5943-7-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com To: Jason Wang Return-path: In-Reply-To: <1369994005-5943-7-git-send-email-jasowang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 31-05-2013 13:53, Jason Wang wrote: > Though the queue were in fact created by open(), we still need to add this check > to be compatible with tuntap which can let mgmt software use a single API to > manage queues. This patch only validates the device name and moves the TUNSETIFF > to a helper. > Signed-off-by: Jason Wang > --- > drivers/net/macvtap.c | 51 ++++++++++++++++++++++++++++++++++++++---------- > 1 files changed, 40 insertions(+), 11 deletions(-) > diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c > index e76484c..eac49cb 100644 > --- a/drivers/net/macvtap.c > +++ b/drivers/net/macvtap.c > @@ -870,6 +870,7 @@ out: > return ret; > } > > + Seems like random whitespace change. > static struct macvlan_dev *macvtap_get_vlan(struct macvtap_queue *q) > { > struct macvlan_dev *vlan; [...] WBR, Sergei