From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>
Cc: "Davidlohr Bueso" <davidlohr.bueso@hp.com>,
"Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: skbuff: use _RET_IP_
Date: Fri, 31 May 2013 21:51:34 +0400 [thread overview]
Message-ID: <51A8E326.70800@cogentembedded.com> (raw)
In-Reply-To: <1370019292.10556.79.camel@joe-AO722>
Hello.
On 05/31/2013 08:54 PM, Joe Perches wrote:
>>> Don't use a standalone gcc compiled program to
>>> determine what the kernel outputs.
> []
>>> The kernel output is;
>>> printk("0x%lx\n", 0x100ul) 0x100
>>> printk("%p\n", (void *)0x100ul) 00000100
>>> printk("%#p\n", (void *)0x100ul) 0x00000100
>>> The last one isn't used at all in kernel source. (gcc complains)
>>> It's always "0x%p"
>> I was talking about using "%#lx", not "%#p". I don't see it in your
>> example.
> "0x%lx" and "%#lx" produce the same output in the kernel.
>
> The latter isn't used very often though.
It's already used in the same format string in this case. That's why
I suggested
not to deviate from the existing code.
WBR, Sergei
next prev parent reply other threads:[~2013-05-31 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 21:09 [PATCH] net: skbuff: use _RET_IP_ Davidlohr Bueso
2013-05-29 21:43 ` Sergei Shtylyov
2013-05-30 11:08 ` Bjørn Mork
2013-05-31 1:11 ` Davidlohr Bueso
2013-05-31 5:20 ` Joe Perches
2013-05-31 7:06 ` Bjørn Mork
2013-05-31 14:33 ` Sergei Shtylyov
2013-05-31 16:54 ` Joe Perches
2013-05-31 17:51 ` Sergei Shtylyov [this message]
2013-06-01 0:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8E326.70800@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=davidlohr.bueso@hp.com \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).