From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch" Date: Sun, 02 Jun 2013 11:02:30 +0200 Message-ID: <51AB0A26.6070608@hartkopp.net> References: <1370080751.29224.37.camel@localhost.localdomain> <20130601.193717.2203825358470502762.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: thomas@m3y3r.de Return-path: Received: from mo-p00-ob.rzone.de ([81.169.146.162]:63834 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab3FBJCd (ORCPT ); Sun, 2 Jun 2013 05:02:33 -0400 In-Reply-To: <20130601.193717.2203825358470502762.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hello Thomas, additionally to provide a proper log message it is a usual to provide the coccinelle expression that found the source to be changed. http://lwn.net/Articles/315686/ E.g. like these http://marc.info/?l=linux-netdev&m=135081679626023&w=2 http://marc.info/?l=linux-netdev&m=135194048501621&w=2 http://marc.info/?l=linux-netdev&m=135306967411758&w=2 http://marc.info/?l=linux-netdev&m=135304902302198&w=2 Regards, Oliver On 02.06.2013 04:37, David Miller wrote: > From: Thomas Meyer > Date: Sat, 01 Jun 2013 11:59:11 +0200 > >> >> Signed-off-by: Thomas Meyer > > This obscure reference to the cocci path you used to find/fix > this problem is insufficient in detail for a commit log message. > > You must explain exactly what the problem is, and how you fixed > it, in full sentences. You must make your commit header lin > subject more appropriate as well. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >