From: Michal Simek <monstr@monstr.eu>
To: "Jens Renner (EFE)" <renner@efe-gmbh.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: xilinx_emaclite: set protocol selector bits when writing ANAR
Date: Mon, 03 Jun 2013 11:38:26 +0200 [thread overview]
Message-ID: <51AC6412.5090202@monstr.eu> (raw)
In-Reply-To: <51AB6680.7010507@efe-gmbh.de>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On 06/02/2013 05:36 PM, Jens Renner (EFE) wrote:
> This patch sets the protocol selector bits (4:0) of the PHY's MII_ADVERTISE
> register (ANAR) when writing ADVERTISE_ALL. The protocol selector bits are
> indicating IEEE 803.3u support and are fixed / read-only on some PHYs. Not
> setting them correctly on others (like TI DP83630) makes the PHY fall back
> to 10M HDX mode which should be avoided.
>
> Tested for TI DP83630 PHY on Microblaze platform.
>
> Signed-off-by: Jens Renner <renner@...-gmbh.de>
You should probably fix this line too.
Thanks,
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-06-03 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 15:36 [PATCH v3] net: ethernet: xilinx_emaclite: set protocol selector bits when writing ANAR Jens Renner (EFE)
2013-06-03 9:38 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC6412.5090202@monstr.eu \
--to=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=renner@efe-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).