From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Ariel Elior <ariele@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>
Subject: Re: [PATCH net] bnx2x: fix TCP offload for tunneling ipv4 over ipv6
Date: Mon, 03 Jun 2013 15:27:47 +0400 [thread overview]
Message-ID: <51AC7DB3.70908@cogentembedded.com> (raw)
In-Reply-To: <1370251721-24668-1-git-send-email-dmitry@broadcom.com>
Hello.
On 03-06-2013 13:28, Dmitry Kravkov wrote:
> FW was initialized with data from wrong header, this caused TSO packets
> have wrong IP csum.
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index c80f1d2..37c1495 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -3198,11 +3198,11 @@ static u32 bnx2x_xmit_type(struct bnx2x *bp, struct sk_buff *skb)
> rc |= XMIT_CSUM_TCP;
>
> if (skb_is_gso_v6(skb)) {
> - rc |= (XMIT_GSO_V6 | XMIT_CSUM_TCP | XMIT_CSUM_V6);
> + rc |= (XMIT_GSO_V6 | XMIT_CSUM_TCP);
Maybe it's time to drop the useless ()?
> if (rc & XMIT_CSUM_ENC)
> rc |= XMIT_GSO_ENC_V6;
> } else if (skb_is_gso(skb)) {
> - rc |= (XMIT_GSO_V4 | XMIT_CSUM_V4 | XMIT_CSUM_TCP);
> + rc |= (XMIT_GSO_V4 | XMIT_CSUM_TCP);
Oh, here as well...
WBR, Sergei
next prev parent reply other threads:[~2013-06-03 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:28 [PATCH net] bnx2x: fix TCP offload for tunneling ipv4 over ipv6 Dmitry Kravkov
2013-06-03 11:27 ` Sergei Shtylyov [this message]
2013-06-03 11:45 ` Dmitry Kravkov
2013-06-05 0:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC7DB3.70908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ariele@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).