From: Michal Simek <monstr@monstr.eu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: monstr@monstr.eu, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] net: emaclite: include linux/of_irq.h
Date: Tue, 04 Jun 2013 10:46:55 +0200 [thread overview]
Message-ID: <51ADA97F.2010308@monstr.eu> (raw)
In-Reply-To: <2240834.ApHHSrFxQG@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On 06/04/2013 10:44 AM, Arnd Bergmann wrote:
> On Tuesday 04 June 2013 10:21:01 Michal Simek wrote:
>> On 06/03/2013 11:39 PM, Arnd Bergmann wrote:
>>> The emaclite driver now calls of_irq_to_resource, which is
>>> declared in linux/of_irq.h. Without this patch, I get a build
>>> error on ARM.
>>
>> What about to just change it to use platform_get_resource()?
>> I will test it.
>
> Yes, that would work too. It seems the driver predates the automatic
> generation of resources for IRQs and MMIO registers.
>
> If you change the IRQ resource to platform_get_resource, you should
> change the other one as well.
Yep. I have done that changes. Let me test them on real hw
and I will send them soon.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-06-04 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 21:39 [PATCH] net: emaclite: include linux/of_irq.h Arnd Bergmann
2013-06-04 8:21 ` Michal Simek
2013-06-04 8:44 ` Arnd Bergmann
2013-06-04 8:46 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADA97F.2010308@monstr.eu \
--to=monstr@monstr.eu \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).