From: Chen Gang <gang.chen@asianux.com>
To: David Miller <davem@davemloft.net>
Cc: David.Laight@ACULAB.COM, andy.shevchenko@gmail.com,
edumazet@google.com, pshelar@nicira.com, mgorman@suse.de,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH v3] include/linux/skbuff.h: using '(__u16) ~0U' instead of '~0U'
Date: Wed, 05 Jun 2013 19:15:57 +0800 [thread overview]
Message-ID: <51AF1DED.6050305@asianux.com> (raw)
In-Reply-To: <20130605.013601.2203042571724866964.davem@davemloft.net>
On 06/05/2013 04:36 PM, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Wed, 05 Jun 2013 08:54:22 +0800
>
>> >
>> > Both 'transport_header' and 'mac_header' are __u16, which are
>> > never equal to '~0U'.
>> >
>> > So need use '(__u16) ~0U' instead of '~0U'.
>> >
>> > The related warning (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>> > include/linux/skbuff.h:1587:2: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>> > ...
>> >
>> > Use meaningful macro instead of hard code number, and better to
>> > initialize 'skb->transport_header' in __alloc_skb_head(), too.
>> >
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Your patch doesn't apply to the tree because this has been fixed already
> for several days by using "typeof(x) ~0U"
>
>
OK, thanks.
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-06-05 11:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 6:03 [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U' Chen Gang
2013-05-30 9:55 ` Chen Gang
2013-05-30 15:30 ` Ben Hutchings
2013-06-03 8:52 ` Chen Gang
2013-05-31 21:05 ` Andy Shevchenko
2013-06-03 9:23 ` Chen Gang
2013-06-03 10:14 ` Andy Shevchenko
2013-06-03 10:51 ` Chen Gang
2013-06-03 11:24 ` [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' " Chen Gang
2013-06-03 11:34 ` Andy Shevchenko
2013-06-03 11:46 ` Chen Gang
2013-06-03 12:26 ` David Laight
2013-06-03 12:47 ` David Laight
2013-06-05 0:44 ` Chen Gang
2013-06-05 0:54 ` [PATCH v3] include/linux/skbuff.h: using '(__u16) " Chen Gang
2013-06-05 8:36 ` David Miller
2013-06-05 11:15 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF1DED.6050305@asianux.com \
--to=gang.chen@asianux.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).