From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4 0/8] sh_eth: deal with #ifdef'fery Date: Thu, 06 Jun 2013 18:36:45 +0400 Message-ID: <51B09E7D.10703@cogentembedded.com> References: <201306060106.51082.sergei.shtylyov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , Nobuhiro Iwamatsu , SH-Linux To: Magnus Damm Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 06-06-2013 7:25, Magnus Damm wrote: >> This series deals mostly with excess #ifdef'fery in the 'sh_eth' driver. >> It doesn't yet get rid of all the #ifdef'fery but that's a matter of another >> patchset. The last patch (it was almost in the middle of the series before), >> contrarywise, adds one missing #ifdef... >> [1/8] sh_eth: remove #ifdef around EDSR and GECMR bit definitions >> [2/8] sh_eth: use EDSR_ENALL to set EDSR >> [3/8] sh_eth: remove duplicate sh_eth_set_duplex() definitions >> [4/8] sh_eth: remove SH_ETH_HAS_TSU >> [5/8] sh_eth: add IRQ flags to 'struct sh_eth_cpu_data' >> [6/8] sh_eth: remove #ifdef around sh_eth_select_mii() >> [7/8] sh_eth: consolidate sh_eth_reset() >> [8/8] sh_eth: enclose PM code into #ifdef CONFIG_PM > Thanks for your work on this. In this case it's mostly Iwamatsu-san's work. > I'm looking forward to a sh-eth driver without #ifdef hell. I've started the next patch series with exactly this purpose. > It may be just me misunderstanding, but the other day I noticed that > external PHY handling seems broken in the sh-eth driver. I tried to > enable a micron PHY driver but could not make the pieces fit together. > I also wanted to use an external IRQ for the PHY link notification, > but since I couldn't even get the micron PHY driver going in polling > mode I decided to give up. Do you know the status of external PHY > support in the sh-eth driver? Works for me on the BOCK-W board. As for PHY IRQs, driver forces polling on all PHYs. > Cheers, > / magnus WBR, Sergei