* [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment
@ 2013-06-07 0:07 Daniel Borkmann
2013-06-07 1:20 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2013-06-07 0:07 UTC (permalink / raw)
To: davem; +Cc: netdev
We have the minimal inline helper tcp_skb_mss to access
skb_shinfo(skb)->gso_size, so also use it here to get mss.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
net/ipv4/tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index b5d4ad9..6a1cf95 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
oldlen = (u16)~skb->len;
__skb_pull(skb, thlen);
- mss = skb_shinfo(skb)->gso_size;
+ mss = tcp_skb_mss(skb);
if (unlikely(skb->len <= mss))
goto out;
@@ -3071,7 +3071,7 @@ found:
flush |= *(u32 *)((u8 *)th + i) ^
*(u32 *)((u8 *)th2 + i);
- mss = skb_shinfo(p)->gso_size;
+ mss = tcp_skb_mss(p);
flush |= (len - 1) >= mss;
flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment
2013-06-07 0:07 [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment Daniel Borkmann
@ 2013-06-07 1:20 ` Eric Dumazet
2013-06-07 5:43 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2013-06-07 1:20 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: davem, netdev
On Fri, 2013-06-07 at 02:07 +0200, Daniel Borkmann wrote:
> We have the minimal inline helper tcp_skb_mss to access
> skb_shinfo(skb)->gso_size, so also use it here to get mss.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> net/ipv4/tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index b5d4ad9..6a1cf95 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
> oldlen = (u16)~skb->len;
> __skb_pull(skb, thlen);
>
> - mss = skb_shinfo(skb)->gso_size;
> + mss = tcp_skb_mss(skb);
Conceptually, this is part of the GRO/GSO layer.
It would be nice to move this stuff in net/ipv4/tcp_offload.c
to makes things explicit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment
2013-06-07 1:20 ` Eric Dumazet
@ 2013-06-07 5:43 ` Daniel Borkmann
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2013-06-07 5:43 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, netdev
On 06/07/2013 03:20 AM, Eric Dumazet wrote:
> On Fri, 2013-06-07 at 02:07 +0200, Daniel Borkmann wrote:
>> We have the minimal inline helper tcp_skb_mss to access
>> skb_shinfo(skb)->gso_size, so also use it here to get mss.
>>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> ---
>> net/ipv4/tcp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>> index b5d4ad9..6a1cf95 100644
>> --- a/net/ipv4/tcp.c
>> +++ b/net/ipv4/tcp.c
>> @@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
>> oldlen = (u16)~skb->len;
>> __skb_pull(skb, thlen);
>>
>> - mss = skb_shinfo(skb)->gso_size;
>> + mss = tcp_skb_mss(skb);
>
> Conceptually, this is part of the GRO/GSO layer.
>
> It would be nice to move this stuff in net/ipv4/tcp_offload.c
> to makes things explicit.
Agreed, will do.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-07 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-07 0:07 [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment Daniel Borkmann
2013-06-07 1:20 ` Eric Dumazet
2013-06-07 5:43 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).