From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Hayes Wang <hayeswang@realtek.com>,
Stefan Bader <stefan.bader@canonical.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.
Date: Mon, 10 Jun 2013 13:12:10 +0200 [thread overview]
Message-ID: <51B5B48A.5040807@googlemail.com> (raw)
In-Reply-To: <5197936C.6090607@googlemail.com>
On 18.05.2013 16:42, Holger Hoffstätte wrote:
> On 18.05.2013 13:24, Francois Romieu wrote:
>> 8168evl offloaded checksums are wrong since commit
>> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
>> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
>> appear as UDP checksums which are wrong by the count of added bytes.
>>
>> It isn't worth compensating. Let the driver checksum.
>>
>> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
>> written.
>>
>> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
>
> Tested again, still working for me.
>
> Tested-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>
ping:
As far as I can tell this patch is still not in -stable 3.9.5 or queued
up for the next iteration.
Commit in Linus' tree is b423e9ae49d78ea3f53b131c8d5a6087aed16fd6
thanks :)
-h
next prev parent reply other threads:[~2013-06-10 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 11:24 [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets Francois Romieu
2013-05-18 14:42 ` Holger Hoffstätte
2013-06-10 11:12 ` Holger Hoffstätte [this message]
2013-06-10 21:54 ` Francois Romieu
2013-05-20 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5B48A.5040807@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).