From: John Fastabend <john.r.fastabend@intel.com>
To: Narendra_K@Dell.com
Cc: john.fastabend@gmail.com, bhutchings@solarflare.com,
bjorn@mork.no, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [RFC PATCH] Initialize dev_id sysfs attribute to -1 by default
Date: Mon, 10 Jun 2013 11:43:04 -0700 [thread overview]
Message-ID: <51B61E38.6000908@intel.com> (raw)
In-Reply-To: <E31FB011129F30488D5861F383904915210BA89DFD@BLRX7MCDC201.AMER.DELL.COM>
[...]
> Hi John, thank you for the inputs. It was set to -1 to differentiate between driver setting it to zero and the default value zero.
>
The point I was trying to make here is setting it to a single
digit 0, 1, or -1 doesn't really help in a virtualized environment
where you may not have access to the PCI topology, serial #s, etc.
You need a system-wide unique id.
Anyways looks like your on the right track.
.John
next prev parent reply other threads:[~2013-06-10 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 13:25 [RFC PATCH] Initialize dev_id sysfs attribute to -1 by default Narendra_K
2013-05-30 13:38 ` Bjørn Mork
2013-05-31 12:17 ` Narendra_K
2013-06-07 14:45 ` John Fastabend
2013-06-07 15:23 ` Ben Hutchings
2013-06-07 17:15 ` John Fastabend
2013-06-10 18:11 ` Narendra_K
2013-06-10 18:43 ` John Fastabend [this message]
2013-06-07 17:02 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B61E38.6000908@intel.com \
--to=john.r.fastabend@intel.com \
--cc=Narendra_K@Dell.com \
--cc=bhutchings@solarflare.com \
--cc=bjorn@mork.no \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).