From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX
Date: Tue, 11 Jun 2013 22:09:52 +0400 [thread overview]
Message-ID: <51B767F0.6020304@cogentembedded.com> (raw)
In-Reply-To: <1370962642-12097-1-git-send-email-markos.chandras@imgtec.com>
Hello.
On 11-06-2013 18:57, Markos Chandras wrote:
> The Vortex driver depends on PCI with optional support for EISA.
> This fixes build problems when EISA is selected but not PCI.
> drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of
> function 'pci_iomap' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of
> function 'pci_iounmap' [-Werror=implicit-function-declaration]
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
The proper way to address this is probably add empty *static inline*
function implementations for CONFIG_PCI=n case to the header file, same
as was done with pci_{request|release}_regions() for this same file
several years ago...
WBR, Sergei
next prev parent reply other threads:[~2013-06-11 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 14:57 [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX Markos Chandras
2013-06-11 16:30 ` Paul Gortmaker
2013-06-11 17:48 ` Markos Chandras
2013-06-11 20:16 ` Paul Gortmaker
2013-06-11 20:29 ` Markos Chandras
2013-06-11 20:45 ` Sergei Shtylyov
2013-06-13 8:34 ` David Miller
2013-06-13 8:36 ` Markos Chandras
2013-06-11 18:09 ` Sergei Shtylyov [this message]
2013-06-11 18:28 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B767F0.6020304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=markos.chandras@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).