From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net,
Willem de Bruijn <willemb@google.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Eilon Greenstien <eilong@broadcom.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
Amir Vadai <amirv@mellanox.com>,
Alex Rosenbaum <alexr@mellanox.com>,
Avner Ben Hanoch <avnerb@mellanox.com>,
Or Kehati <ork@mellanox.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v2 net-next 3/3] net: add socket option for low latency polling
Date: Wed, 12 Jun 2013 15:58:57 +0300 [thread overview]
Message-ID: <51B87091.4050205@linux.intel.com> (raw)
In-Reply-To: <51B86FA3.1030306@linux.intel.com>
On 12/06/2013 15:54, Eliezer Tamir wrote:
> On 12/06/2013 15:44, Eric Dumazet wrote:
>> On Wed, 2013-06-12 at 14:20 +0300, Eliezer Tamir wrote:
>>> adds a socket option for low latency polling.
>>> This allows overriding the global sysctl value with a per-socket one.
>>>
>>> Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
>>> ---
>>
>> It seems EXPORT_SYMBOL_GPL(sysctl_net_ll_poll) can now be removed ?
>
> I think we would need it for poll.
>
> Poll needs a way that is not dependent on any individual socket to know
> how long to busy-wait, since we have to know it before we poll any
> individual socket.
Or maybe, since the time constants seem to be different, we should have
two separate sysctl values, one for read and another for poll?
(and then the one for read does not need to be exported to modules.)
next prev parent reply other threads:[~2013-06-12 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 11:19 [PATCH v2 net-next 0/3] net: low latency sockets follow ups Eliezer Tamir
2013-06-12 11:19 ` [PATCH v2 net-next 1/3] net: remove NET_LL_RX_POLL config menue Eliezer Tamir
2013-06-12 11:20 ` [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int Eliezer Tamir
2013-06-12 12:04 ` Avner Ben Hanoch
2013-06-12 12:44 ` Eliezer Tamir
2013-06-12 11:20 ` [PATCH v2 net-next 3/3] net: add socket option for low latency polling Eliezer Tamir
2013-06-12 12:44 ` Eric Dumazet
2013-06-12 12:54 ` Eliezer Tamir
2013-06-12 12:58 ` Eliezer Tamir [this message]
2013-06-12 13:55 ` Eric Dumazet
2013-06-12 11:22 ` [PATCH v2 sockperf] sockperf: add SO_LL socketop support Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B87091.4050205@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=alexr@mellanox.com \
--cc=amirv@mellanox.com \
--cc=andi@firstfloor.org \
--cc=avnerb@mellanox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer@tamir.org.il \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=ork@mellanox.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).