From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
Date: Thu, 13 Jun 2013 09:57:40 +0900 [thread overview]
Message-ID: <51B91904.8070001@renesas.com> (raw)
In-Reply-To: <51B8CB1B.9020304@cogentembedded.com>
Hi,
(2013/06/13 4:25), Sergei Shtylyov wrote:
> On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
< snip >
>> +#if defined(CONFIG_ARCH_R8A7740)
>> + /*
>> + * In case of almost GETHER/ETHERs, the Receive Frame State
>
> Erm, minor nit: it seems you forgot "all" after "almost". Hence it's probably worth resubmitting...
>
Thank you for the point. I will fix it and resubmit a patch for "net.git".
Best regards,
Yoshihiro Shimoda
>> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
>> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
>> + * bits are from bit 25 to bit 16. So, the driver needs right
>> + * shifting by 16.
>> + */
>> + desc_status >>= 16;
>> +#endif
>> +
>
> WBR, Sergei
>
>
prev parent reply other threads:[~2013-06-13 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 1:33 [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740 Shimoda, Yoshihiro
2013-06-12 14:15 ` Sergei Shtylyov
2013-06-12 19:13 ` Sergei Shtylyov
2013-06-12 19:55 ` David Miller
2013-06-12 20:03 ` Sergei Shtylyov
2013-06-12 19:25 ` Sergei Shtylyov
2013-06-13 0:57 ` Shimoda, Yoshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B91904.8070001@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).