From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: dinguyen@altera.com, netdev@vger.kernel.org, dinh.linux@gmail.com
Subject: Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used
Date: Thu, 13 Jun 2013 11:56:33 +0200 [thread overview]
Message-ID: <51B99751.6050006@st.com> (raw)
In-Reply-To: <20130613.013152.180392586047160961.davem@davemloft.net>
Hello David
On 6/13/2013 10:31 AM, David Miller wrote:
> From: <dinguyen@altera.com>
> Date: Wed, 12 Jun 2013 11:05:03 -0500
>
>> From: Dinh Nguyen <dinguyen@altera.com>
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function:
>> stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74:
>> error: expected ) before __func__
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> CC: David S. Miller <davem@davemloft.net>
>
> Applied, but this debugging mechanism is completely unacceptable.
I agree with you, I do not like it too
this debug code is quite old and fixed to the initial driver version.
I had used it to the initial debug so I must rework it (also because
debug has to be guarantee w/o errors and w/o ifdef proliferation)
I'll prepare a patch asap.
Peppe
>
> We have a dynamic, run time, way to do stuff like this without
> peppering up a driver with gross ifdefs.
>
> This driver must be converted over to use "netif_msg_*()" et al.
> to guard message logging of different types of events.
>
>
prev parent reply other threads:[~2013-06-13 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 16:05 [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used dinguyen
2013-06-13 8:31 ` David Miller
2013-06-13 9:56 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B99751.6050006@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).