From: Stephen Moorby <steve.moorby@ntlworld.com>
To: David Miller <davem@davemloft.net>
Cc: jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/net: param for lapbether for specific ethernet device
Date: Wed, 19 Jun 2013 21:19:31 +0100 [thread overview]
Message-ID: <51C21253.2070308@ntlworld.com> (raw)
In-Reply-To: <20130619.121802.2112053686285060471.davem@davemloft.net>
I will be using an Ubuntu 10.04 kernel with the 'eth_dev' module
parameter patch. I appreciate a better solution needs to be designed
but it is not one I can contribute to. I still advocate the patch as an
improvement on the current non functional situation.
On 19/06/13 20:18, David Miller wrote:
> From: Stephen Moorby <steve.moorby@ntlworld.com>
> Date: Wed, 19 Jun 2013 16:26:53 +0100
>
>> The lapbether driver binds to the first ethernet device that comes up.
>> This causes problems in hardware with multiple ethernet interfaces,
>> potentially resulting in the LAPB traffic on the wrong interface.
>> Have added a module parameter 'eth_dev' to specify the ethernet
>> interface over which lapbether should operate. The module behaves
>> as before if no device is specified.
>>
>> Patch created on linux-next 18-Jun-2013.
>> Tested on 2.6.32-45-generic.
>>
>> Signed-off-by: Stephen Moorby <steve.moorby@ntlworld.com>
> I rejected this patch last night, stating that module parameters are
> deeply discouraged and therefore you need to create a runtime mechanism
> to control this.
>
next prev parent reply other threads:[~2013-06-19 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 15:26 [PATCH 1/1] drivers/net: param for lapbether for specific ethernet device Stephen Moorby
2013-06-19 19:18 ` David Miller
2013-06-19 20:19 ` Stephen Moorby [this message]
2013-06-19 22:48 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-06-19 8:21 Stephen Moorby
2013-06-19 8:37 ` David Miller
2013-06-19 13:47 ` Sergei Shtylyov
2013-06-19 16:16 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C21253.2070308@ntlworld.com \
--to=steve.moorby@ntlworld.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).