From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH net-next 7/8] vxlan: Add tx-vlan offload support.
Date: Thu, 20 Jun 2013 16:29:54 +0400 [thread overview]
Message-ID: <51C2F5C2.5050502@cogentembedded.com> (raw)
In-Reply-To: <1371713217-8310-1-git-send-email-pshelar@nicira.com>
Hello.
On 20-06-2013 11:26, Pravin B Shelar wrote:
> Following patch allows transmit side vlan offload for vxlan
> devices.
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> ---
> drivers/net/vxlan.c | 15 ++++++++++++++-
> 1 files changed, 14 insertions(+), 1 deletions(-)
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index e53c947..a7feba4 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
[...]
> @@ -1049,13 +1050,23 @@ int vxlan_xmit_skb(struct net *net, struct vxlan_handler *vh,
[...]
> + if (vlan_tx_tag_present(skb)) {
> + if (unlikely(!__vlan_put_tag(skb,
> + skb->vlan_proto,
> + vlan_tx_tag_get(skb)))) {
> + return -ENOMEM;
> + }
You haven't run this patch thru scripts/checkpatch.pl, have you? It
should have warned you about using {} on single statement branch.
> + skb->vlan_tci = 0;
> + }
> +
WBR, Sergei
prev parent reply other threads:[~2013-06-20 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 7:26 [PATCH net-next 7/8] vxlan: Add tx-vlan offload support Pravin B Shelar
2013-06-20 12:29 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2F5C2.5050502@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).