From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush
Date: Thu, 20 Jun 2013 16:47:59 +0400 [thread overview]
Message-ID: <51C2F9FF.4090702@cogentembedded.com> (raw)
In-Reply-To: <20130620114813.GA17373@redhat.com>
Hello.
On 20-06-2013 15:48, Michael S. Tsirkin wrote:
> vhost_net_ubuf_put_and_wait has a confusing name:
> it will actually also free it's argument.
> Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
Please also specify that commit's summary line in parens.
> vhost_net_flush tries to use the argument after passing it
> to vhost_net_ubuf_put_and_wait, this results
> in use after free.
> To fix, don't free the argument in vhost_net_ubuf_put_and_wait,
> add an new API for callers that want to free ubufs.
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
WBR, Sergei
next prev parent reply other threads:[~2013-06-20 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 11:48 [PATCH net] vhost-net: fix use-after-free in vhost_net_flush Michael S. Tsirkin
2013-06-20 12:47 ` Sergei Shtylyov [this message]
2013-06-21 6:50 ` Jason Wang
2013-06-21 7:20 ` Asias He
2013-06-24 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2F9FF.4090702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).