From: Amir Vadai <amirv.mellanox@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Amir Vadai <amirv@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>
Subject: Re: [PATCH net-next 07/11] net/mlx4_en: Add prints when TX timeout occurs
Date: Fri, 21 Jun 2013 08:31:49 +0300 [thread overview]
Message-ID: <51C3E545.3020003@gmail.com> (raw)
In-Reply-To: <1371758105.2146.39.camel@joe-AO722>
On 20/06/2013 22:55, Joe Perches wrote:
> On Thu, 2013-06-20 at 22:40 +0300, Amir Vadai wrote:
>> From: Yevgeny Petrilin <yevgenyp@mellanox.com>
>>
>> Debug prints when a TX timeout is detected
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> []
>> @@ -1236,10 +1236,21 @@ static void mlx4_en_tx_timeout(struct net_device *dev)
> []
>> + for (i = 0; i < priv->tx_ring_num; i++) {
>> + if (!netif_tx_queue_stopped(netdev_get_tx_queue(dev, i)))
>> + continue;
>> + en_info(priv, "TX timeout detected on queue: %d,\n"
>> + "QP: 0x%x, CQ: 0x%x,\n"
>> + "Cons index: 0x%x, Prod index: 0x%x\n", i,
>
> Not at dbg level and probably better on a single line.
>
Will be fixed in v1
next prev parent reply other threads:[~2013-06-21 5:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 19:40 [PATCH net-next 00/11] Mellanox driver updates 2013-06-20 Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 01/11] net/mlx4_en: Suppress page allocation failure warnings Amir Vadai
2013-06-20 21:28 ` Eric Dumazet
2013-06-21 5:35 ` Amir Vadai
2013-06-23 8:46 ` Amir Vadai
2013-06-23 15:14 ` Eric Dumazet
2013-06-23 15:17 ` [PATCH net-next] mlx4: allow order-0 memory allocations in RX path Eric Dumazet
2013-06-23 20:17 ` Or Gerlitz
2013-06-23 21:13 ` Eric Dumazet
2013-06-24 14:10 ` Or Gerlitz
2013-06-24 14:09 ` Or Gerlitz
2013-06-25 8:53 ` Or Gerlitz
2013-06-25 23:19 ` David Miller
2013-06-20 19:40 ` [PATCH net-next 02/11] net/mlx4_en: Fix resource leak in error flow Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 03/11] net/mlx4_en: Do not query stats when device port is down Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 04/11] net/mlx4_en: Move register_netdev() to the end of initialization function Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 05/11] net/mlx4_en: Change log level from error to debug for vlan related messages Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 06/11] net/mlx4_en: Fix a race between napi poll function and RX ring cleanup Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 07/11] net/mlx4_en: Add prints when TX timeout occurs Amir Vadai
2013-06-20 19:55 ` Joe Perches
2013-06-21 5:31 ` Amir Vadai [this message]
2013-06-20 19:40 ` [PATCH net-next 08/11] net/mlx4_en: Remove an unnecessary test Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 09/11] net/mlx4_core: Replace sscanf() with kstrtoint() Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 10/11] net/mlx4_core: Add warning in case of command timeouts Amir Vadai
2013-06-20 19:40 ` [PATCH net-next 11/11] net/mlx4_core: Fail device init if num_vfs is negative Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C3E545.3020003@gmail.com \
--to=amirv.mellanox@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).