From: Daniel Borkmann <dborkman@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Pravin B Shelar <pshelar@nicira.com>
Subject: Re: [PATCH net-next] net: udp4: move GSO functions to udp_offload
Date: Mon, 24 Jun 2013 10:51:18 +0200 [thread overview]
Message-ID: <51C80886.9000307@redhat.com> (raw)
In-Reply-To: <1372063295.3301.52.camel@edumazet-glaptop>
On 06/24/2013 10:41 AM, Eric Dumazet wrote:
> On Sat, 2013-06-08 at 12:56 +0200, Daniel Borkmann wrote:
>> Similarly to TCP offloading and UDPv6 offloading, move all related
>> UDPv4 functions to udp_offload.c to make things more explicit. Also,
>> by this, we can make those functions static.
>>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> ---
>> include/net/udp.h | 7 ++--
>> net/ipv4/Makefile | 2 +-
>> net/ipv4/af_inet.c | 9 +----
>> net/ipv4/udp.c | 75 +------------------------------------
>> net/ipv4/udp_offload.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 108 insertions(+), 85 deletions(-)
>> create mode 100644 net/ipv4/udp_offload.c
>
> Daniel, the same could be done for GRE, ie moving GSO stuff into
> net/ipv4/gre_offload.c
>
> Tell me if you do not have the time to do this, I will handle it.
Ok, I can do this today.
Thanks,
Daniel
next prev parent reply other threads:[~2013-06-24 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 10:56 [PATCH net-next] net: udp4: move GSO functions to udp_offload Daniel Borkmann
2013-06-12 7:48 ` David Miller
2013-06-24 8:41 ` Eric Dumazet
2013-06-24 8:51 ` Daniel Borkmann [this message]
2013-06-24 10:25 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C80886.9000307@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).