From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Byungho An <bh74.an@samsung.com>
Cc: netdev@vger.kernel.org, '김국진' <kgene.kim@samsung.com>,
davem@davemloft.net, cpgs@samsung.com
Subject: Re: [PATCH] net: stmmac: fixed operator typo
Date: Fri, 28 Jun 2013 14:59:36 +0200 [thread overview]
Message-ID: <51CD88B8.6050209@st.com> (raw)
In-Reply-To: <015701ce73d2$117b9040$3472b0c0$%an@samsung.com>
On 6/28/2013 9:35 AM, Byungho An wrote:
>
> This patch fixed operator typo from & to ==.
> Due to incorrect operator, the result is incorrect.
>
> Signed-off-by: Byungho An <bh74.an@samsung.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 +++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index c1ad5f4..f088633 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -788,13 +788,13 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
> int interface = priv->plat->interface;
>
> if (priv->dma_cap.pcs) {
> - if ((interface & PHY_INTERFACE_MODE_RGMII) ||
> - (interface & PHY_INTERFACE_MODE_RGMII_ID) ||
> - (interface & PHY_INTERFACE_MODE_RGMII_RXID) ||
> - (interface & PHY_INTERFACE_MODE_RGMII_TXID)) {
> + if ((interface == PHY_INTERFACE_MODE_RGMII) ||
> + (interface == PHY_INTERFACE_MODE_RGMII_ID) ||
> + (interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
> + (interface == PHY_INTERFACE_MODE_RGMII_TXID)) {
> pr_debug("STMMAC: PCS RGMII support enable\n");
> priv->pcs = STMMAC_PCS_RGMII;
> - } else if (interface & PHY_INTERFACE_MODE_SGMII) {
> + } else if (interface == PHY_INTERFACE_MODE_SGMII) {
> pr_debug("STMMAC: PCS SGMII support enable\n");
> priv->pcs = STMMAC_PCS_SGMII;
> }
>
next prev parent reply other threads:[~2013-06-28 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 7:35 [PATCH] net: stmmac: fixed operator typo Byungho An
2013-06-28 12:59 ` Giuseppe CAVALLARO [this message]
2013-07-01 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD88B8.6050209@st.com \
--to=peppe.cavallaro@st.com \
--cc=bh74.an@samsung.com \
--cc=cpgs@samsung.com \
--cc=davem@davemloft.net \
--cc=kgene.kim@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).