From: Richard Weinberger <richard@nod.at>
To: Chen Gang <gang.chen@asianux.com>
Cc: David Miller <davem@davemloft.net>,
richardcochran@gmail.com, netdev@vger.kernel.org,
geert@linux-m68k.org
Subject: Re: [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK_PCH'
Date: Mon, 01 Jul 2013 08:34:24 +0200 [thread overview]
Message-ID: <51D122F0.1000204@nod.at> (raw)
In-Reply-To: <51D11D14.8000706@asianux.com>
Am 01.07.2013 08:09, schrieb Chen Gang:
> On 07/01/2013 01:40 PM, Richard Weinberger wrote:
>> Am 01.07.2013 03:34, schrieb Chen Gang:
>>>> On 06/29/2013 12:23 PM, David Miller wrote:
>>>>>> From: Chen Gang <gang.chen@asianux.com>
>>>>>> Date: Thu, 27 Jun 2013 08:52:07 +0800
>>>>>>
>>>>>>>>>> @@ -73,6 +73,7 @@ config DP83640_PHY
>>>>>>>>>> config PTP_1588_CLOCK_PCH
>>>>>>>>>> tristate "Intel PCH EG20T as PTP clock"
>>>>>>>>>> depends on X86 || COMPILE_TEST
>>>>>> This "depends on X86 || COMPILE_TEST" does not exist in either 'net' or 'net-next'.
>>>>>> Please submit your patches against a clean checkout of the networking GIT tree,
>>>>>> rather than something else such as linux-next.
>>>>
>>>> Oh, really it is, It is my fault (originally I get mail address from
>>>> "./scripts/get_maintainers.pl", but not give additional check on it).
>>>>
>>>> For your information (or implicit suggestion), if one module wants to
>>>> request 'COMPILE_TEST', the platforms (or asm-generic) is recommended to
>>>> try to support it.
>>>>
>>>> It seems I still have the chance to continue discuss about it with
>>>> platform guys. ;-)
>> David told you that your patch does not apply.
>> Not even Linus' tree has "depends on X86 || COMPILE_TEST".
>> Please adjust your patch.
>
>
> Before send the patch, it is better to discuss the "asm-generic"
> whether need consider 'COMPILE_TEST'.
No.
> config COMPILE_TEST
> bool "Compile also drivers which will not load"
> default n
> help
> Some drivers can be compiled on a different platform than they are
> intended to be run on. Despite they cannot be loaded there (or even
> when they load they cannot be used due to missing HW support),
> developers still, opposing to distributors, might want to build such
> drivers to compile-test them.
>
> If you are a developer and want to build everything available, say Y
> here. If you are a user/distributor, say N here to exclude useless
> drivers to be distributed.
>
> I guess, 'COMPILE_TEST' is really useful for UML.
No.
We have explained you more than once what the deal and why UML does not
have ioremap() and friends.
Thanks,
//richard
next prev parent reply other threads:[~2013-07-01 6:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 0:52 [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK_PCH' Chen Gang
2013-06-27 6:48 ` Geert Uytterhoeven
2013-06-27 8:21 ` Chen Gang
2013-06-29 4:23 ` David Miller
2013-07-01 1:34 ` Chen Gang
2013-07-01 5:40 ` Richard Weinberger
2013-07-01 6:09 ` Chen Gang
2013-07-01 6:34 ` Richard Weinberger [this message]
2013-07-01 6:44 ` Chen Gang
2013-07-01 7:32 ` Geert Uytterhoeven
2013-07-01 7:47 ` Chen Gang
2013-07-01 7:56 ` Geert Uytterhoeven
2013-07-01 8:17 ` Chen Gang
2013-07-01 11:12 ` Richard Weinberger
2013-07-01 11:19 ` Geert Uytterhoeven
2013-07-02 0:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D122F0.1000204@nod.at \
--to=richard@nod.at \
--cc=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).