From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro
Date: Mon, 01 Jul 2013 16:58:53 +0400 [thread overview]
Message-ID: <51D17D0D.7040701@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoRQ5OgCuWPC8FW5yBtffNq_E=d=30mE4LB-MxT6GiAwJw@mail.gmail.com>
Hello.
On 01-07-2013 16:12, Magnus Damm wrote:
>>>>> sh_eth_interrupt() uses the same Rx interrupt mask twice to check the
>>>>> interrupt
>>>>> status register -- #define EESR_RX_CHECK and use it instead.
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Thanks for the patch, nice to see that this driver is moving forward.
>> Magnus, BTW, are you content with the amount of cleanup that is currently
>> queued in the Dave Miller's 'net-next.git' repo, or should I move further:
>> e.g., move the SoC specific fields like 'register_type' from the platform
>> data to the driver's internal data structure?
> I just had a look at this particular driver in net-next.git and I
> think it looks very good. Thanks a lot for your efforts!
> Regarding moving further with cleanups, it looks to me that it is now
> possible to build a single kernel image with this driver included and
> use it on multiple SoCs without #ifdef causing trouble. This recent
> development has been needed for mach-shmobile to play well with the
> multiplatform work going on in the ARM architecture. So since that
> seems solved then I'm quite happy with the driver state from a
> cleanliness point of view.
> As for this driver in general, I'd be very happy to see future
> development in these areas:
> - DT support
Full DT support won't be possible due to the driver using procedural
platform data. Partial support will be possible using OF_DEV_AUXDATA()
to assign the platform data to a device.
> - PHY support for r8a7790 Lager
Simon seems to be working on this. AFAIK, we don't yet have R8A7790
based board in our inventory (neither the board manual).
> - PHY IRQ support for r8a7790 Lager
> Let me know if I can help you with remote board access.
Yes, you can.
> Cheers,
> / magnus
WBR, Sergei
prev parent reply other threads:[~2013-07-01 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 22:07 [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro Sergei Shtylyov
2013-06-19 6:47 ` Magnus Damm
2013-06-19 7:50 ` David Miller
2013-06-19 18:27 ` Sergei Shtylyov
2013-07-01 12:12 ` Magnus Damm
2013-07-01 12:58 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D17D0D.7040701@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).