From: Daniel Borkmann <dborkman@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: [PATCH net-next] net: sctp: get rid of SCTP_DBG_TSNS entirely
Date: Mon, 01 Jul 2013 18:33:57 +0200 [thread overview]
Message-ID: <51D1AF75.50907@redhat.com> (raw)
In-Reply-To: <20130701113342.GA3168@hmsreliant.think-freely.org>
On 07/01/2013 01:33 PM, Neil Horman wrote:
> On Mon, Jul 01, 2013 at 11:31:36AM +0200, Daniel Borkmann wrote:
>> After having reworked the debugging framework, Neil and Vlad agreed to
>> get rid of the leftover SCTP_DBG_TSNS code for a couple of reasons:
>>
>> We can use systemtap scripts to investigate these things, we now have
>> pr_debug() helpers that make life easier, and if we really need anything
>> else besides those tools, we will be forced to come up with something
>> better than we have there. Therefore, get rid of this ifdef debugging
>> code entirely for now.
>>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> CC: Vlad Yasevich <vyasevich@gmail.com>
>> CC: Neil Horman <nhorman@tuxdriver.com>
>> ---
>> On top of [PATCH net-next v4 0/2] Rework SCTP debugging framework.
>>
> I think you mean on top of v4 2/2, but regardless:
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> I don't suppose you want to write a stap script to drop in the sourceware
> examples area, in case anyone comes looking for this functionality again? :)
I could put this into my longer-term todo queue, sure, sounds like a plan.
> Thanks
> Neil
next prev parent reply other threads:[~2013-07-01 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 9:31 [PATCH net-next] net: sctp: get rid of SCTP_DBG_TSNS entirely Daniel Borkmann
2013-07-01 11:33 ` Neil Horman
2013-07-01 16:33 ` Daniel Borkmann [this message]
2013-07-01 20:49 ` Neil Horman
2013-07-01 15:35 ` Vlad Yasevich
2013-07-02 7:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1AF75.50907@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).