From: Lars-Peter Clausen <lars@metafoo.de>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
"bzhao@marvell.com" <bzhao@marvell.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"rjw@sisk.pl" <rjw@sisk.pl>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>
Subject: Re: [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm ops
Date: Tue, 02 Jul 2013 21:52:31 +0200 [thread overview]
Message-ID: <51D32F7F.4090606@metafoo.de> (raw)
In-Reply-To: <B8EFE96D1287C24090BAD9D858E15E61734462@sisaex02sj>
On 07/02/2013 09:24 PM, Shuah Khan wrote:
[...]
>>> +#ifdef CONFIG_PM
>>> +/* Power Management Hooks */
>>> +static const struct dev_pm_ops mwifiex_pcie_pm_ops = {
>>> + .suspend = mwifiex_pcie_suspend,
>>> + .resume = mwifiex_pcie_resume,
>>> +};
>>> +#endif
>>> +
>>
>> Is it intended that you do not use SIMPLE_DEV_PM_OPS() like most of the
>> other wifi drivers?
>
> So the reason for this is SIMPLE_DEV_PM_OPS() is defined only when
> CONFIG_PM_SLEEP is enabled. This driver doesn't defines suspend and
> resume when CONFIG_PM is enabled and I didn't want to change that. Hope
> that helps understand why I didn't use SIMPLE_DEV_PM_OPS()
Change the ifdefs to CONFIG_PM_SLEEP and use SIMPLE_DEV_PM_OPS. The driver does
not support runtime PM.
- Lars
next prev parent reply other threads:[~2013-07-02 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 15:24 [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm ops Shuah Khan
2013-07-02 18:30 ` Bing Zhao
2013-07-02 18:51 ` Hauke Mehrtens
2013-07-02 19:07 ` Bing Zhao
2013-07-02 19:24 ` Shuah Khan
2013-07-02 19:52 ` Lars-Peter Clausen [this message]
2013-07-02 22:59 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2013-07-03 16:47 [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm_ops Shuah Khan
2013-07-03 21:46 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D32F7F.4090606@metafoo.de \
--to=lars@metafoo.de \
--cc=bzhao@marvell.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).