From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Jongsung Kim <neidhard.kim@lge.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
Date: Tue, 9 Jul 2013 18:02:23 +0200 [thread overview]
Message-ID: <51DC340F.2060402@atmel.com> (raw)
In-Reply-To: <1373358960-10900-1-git-send-email-neidhard.kim@lge.com>
On 09/07/2013 10:36, Jongsung Kim :
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.10+
Thanks for having spotted that.
Best regards,
> ---
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index c89aa41..b4e0dc8 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
> static void macb_configure_caps(struct macb *bp)
> {
> if (macb_is_gem(bp)) {
> - if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> + if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
> }
> }
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-07-09 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 8:36 [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit Jongsung Kim
2013-07-09 16:02 ` Nicolas Ferre [this message]
2013-07-09 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC340F.2060402@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=neidhard.kim@lge.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).