From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, dwmw2@infradead.org,
eliezer@tamir.org.il
Subject: Re: [PATCH net-next] net: rename low latency sockets functions to busy poll
Date: Wed, 10 Jul 2013 06:29:16 +0300 [thread overview]
Message-ID: <51DCD50C.6070606@linux.intel.com> (raw)
In-Reply-To: <20130709.160611.636749585237773459.davem@davemloft.net>
On 10/07/2013 02:06, David Miller wrote:
> From: Jonathan Corbet <corbet@lwn.net>
> Date: Tue, 9 Jul 2013 16:25:14 -0600
>
>> On Mon, 08 Jul 2013 16:20:34 +0300
>> Eliezer Tamir <eliezer.tamir@linux.intel.com> wrote:
>>
>>> Rename POLL_LL to POLL_BUSY_LOOP.
>>
>> So pardon me if I speak out of turn, but it occurs to me to
>> wonder...should the SO_LL socket option be renamed in a similar fashion
>> before this interface escapes into the wild?
>
> Sure and we can rename include/net/ll_poll.h to something more
> fitting as well.
>
> I'll make sure this happens before 3.11 gets even close to release.
David,
If the following names changes are acceptable I will try to send out
a patch today.
1. include/net/ll_poll.h -> include/net/busy_poll.h
2. ndo_ll_poll -> ndo_busy_poll
- not technically accurate since the ndo callback does not itself busy
poll, it's just used to implement it.
maybe ndo_napi_id_poll? or ndo_id_poll? I don't really like any of them,
so a suggestion would be nice.
3. sysctl_net_ll_{read,poll} -> sysctl_net_busy_{read,poll}
- along with matching file name changes.
4. {sk,skb}_mark_ll -> {sk,skb}_mark_napi_id
5. LL_SO -> BUSY_POLL_SO
Are you OK with the names?
Did I miss anything?
Thanks,
Eliezer
next prev parent reply other threads:[~2013-07-10 3:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:20 [PATCH net-next] net: rename low latency sockets functions to busy poll Eliezer Tamir
2013-07-08 16:37 ` Linus Torvalds
2013-07-08 17:14 ` Eliezer Tamir
2013-07-08 19:37 ` Linus Torvalds
2013-07-08 19:46 ` Eliezer Tamir
2013-07-08 19:59 ` Stephen Hemminger
2013-07-08 20:05 ` Stephen Hemminger
2013-07-08 20:10 ` Linus Torvalds
2013-07-09 2:27 ` David Miller
2013-07-09 22:25 ` Jonathan Corbet
2013-07-09 23:06 ` David Miller
2013-07-10 3:29 ` Eliezer Tamir [this message]
2013-07-10 4:41 ` David Miller
2013-07-10 5:21 ` Eliezer Tamir
2013-07-10 6:10 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DCD50C.6070606@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=eliezer@tamir.org.il \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).