netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pravin Shelar <pshelar@nicira.com>,
	netdev@vger.kernel.org, stephen@networkplumber.org,
	joseph.gasparakis@intel.com, jesse@nicira.com
Subject: Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload
Date: Thu, 11 Jul 2013 10:58:37 -0700	[thread overview]
Message-ID: <51DEF24D.4020101@intel.com> (raw)
In-Reply-To: <1373550706.4600.38.camel@edumazet-glaptop>

On 07/11/2013 06:51 AM, Eric Dumazet wrote:
> On Thu, 2013-07-11 at 00:45 -0700, Pravin Shelar wrote:
>
>> Nice speculation ;)
> Indeed ;) Sorry Pravin !
>
>> I did some digging and found following commit causing problem with GRE
>> TSO on bnx setup.
> Thanks for taking care of this problem.
>
>

I may have found another issue, but I don't think it is related to my
patch.  Specifically it seems like there is some MTU calculation
somewhere that is is off by 14 bytes when using gretap.

I'm just setting up an endpoint and using it back to back with the
following commands:
 ip link add tun0 type gretap remote 192.168.11.129 local 192.168.11.1
 ifconfig tun0 192.168.100.1/24

When I try to ping with a size of 1421 or more, it is being dropped and
being counted as a tx error for the tunnel.  It looks like 3.9 doesn't
have this issue.  I'll try to figure out the root cause before the end
of today.

Thanks,

Alex

  reply	other threads:[~2013-07-11 17:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11  0:05 [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload Alexander Duyck
2013-07-11  0:42 ` Eric Dumazet
2013-07-11  1:43   ` Eric Dumazet
2013-07-11  2:30     ` Alexander Duyck
2013-07-11  2:37       ` Eric Dumazet
2013-07-11  2:23   ` Cong Wang
2013-07-11  7:45   ` Pravin Shelar
2013-07-11  8:14     ` David Miller
2013-07-11  8:31       ` Dmitry Kravkov
2013-07-11 13:51     ` Eric Dumazet
2013-07-11 17:58       ` Alexander Duyck [this message]
2013-07-11 19:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DEF24D.4020101@intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse@nicira.com \
    --cc=joseph.gasparakis@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).