From: John Fastabend <john.fastabend@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <therbert@google.com>,
netdev <netdev@vger.kernel.org>
Subject: locating the 'tc actions' hook
Date: Wed, 31 Jul 2013 14:19:10 -0700 [thread overview]
Message-ID: <51F97F4E.5070102@gmail.com> (raw)
Hi Jamal,
I'm trying to sort out why I would use 'tc actions' and exactly
what it is doing.
Its clear I think adding one or more actions to filters will be
used in the classifier via tcf_exts_exec() through the classify
hook called from a qdisc.
This is your standard
# tc filter add ... {u32|fw|tcindex|route|...} ... action ...
When these actions get configured the specific actions tc_action_ops
will be used to init the action create the hash 'tcf_hash_create' and
parse the options. All this I can follow in ./net/sched/
But the actions netlink hook does this,
tc_ctl_action()
tcf_action_add()
tcf_action_init() <- inserts action in the table
So at this point we have the entry in the table but I must be missing
where the tc_action_ops act() is going to be called because its not via
tcf_exts_exec().
Am I missing something obvious here? Is there a way to link them to
filters? Sorry if it turns out to be a stupid question.
My motivation here is to use the filters/actions outside the qdisc lock
for mq, mqprio, and the ingress qdisc.
.John
--
John Fastabend Intel Corporation
next reply other threads:[~2013-07-31 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 21:19 John Fastabend [this message]
2013-08-01 11:40 ` locating the 'tc actions' hook Jamal Hadi Salim
2013-08-01 23:18 ` John Fastabend
2013-08-02 18:46 ` John Fastabend
2013-08-03 11:49 ` Jamal Hadi Salim
2013-08-03 11:47 ` Jamal Hadi Salim
2013-08-05 16:11 ` John Fastabend
2013-08-12 0:55 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F97F4E.5070102@gmail.com \
--to=john.fastabend@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).