From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH net-next v5 6/7] vxlan: Add tx-vlan offload support.
Date: Thu, 01 Aug 2013 17:11:47 +0400 [thread overview]
Message-ID: <51FA5E93.3070308@cogentembedded.com> (raw)
In-Reply-To: <1375312487-18789-1-git-send-email-pshelar@nicira.com>
Hello.
On 01-08-2013 3:14, Pravin B Shelar wrote:
> Following patch allows transmit side vlan offload for vxlan
> devices.
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> ---
> v2-v3:
> - Set NETIF_F_HW_VLAN_STAG_TX feature.
> - Added WARN on vlan tag push.
> - Fixed hw_features.
> ---
> drivers/net/vxlan.c | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index f9c7c75..2f35a2b 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
[...]
> @@ -1123,13 +1124,25 @@ int vxlan_xmit_skb(struct net *net, struct vxlan_sock *vs,
[...]
> + if (vlan_tx_tag_present(skb)) {
> + if (unlikely(!__vlan_put_tag(skb,
> + skb->vlan_proto,
> + vlan_tx_tag_get(skb)))) {
> + WARN_ON(1);
> + return -ENOMEM;
> + }
if (WARN_ON(!__vlan_put_tag(skb,
skb->vlan_proto,
vlan_tx_tag_get(skb))))
return -ENOMEM;
should be equivalent.
WBR, Sergei
next prev parent reply other threads:[~2013-08-01 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 23:14 [PATCH net-next v5 6/7] vxlan: Add tx-vlan offload support Pravin B Shelar
2013-08-01 13:11 ` Sergei Shtylyov [this message]
2013-08-01 17:24 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA5E93.3070308@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).