From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8809CC43381 for ; Thu, 28 Mar 2019 02:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 532E6206C0 for ; Thu, 28 Mar 2019 02:05:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iG5GAyxM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbfC1CFI (ORCPT ); Wed, 27 Mar 2019 22:05:08 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44077 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfC1CFH (ORCPT ); Wed, 27 Mar 2019 22:05:07 -0400 Received: by mail-pg1-f193.google.com with SMTP id i2so10822687pgj.11 for ; Wed, 27 Mar 2019 19:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xt0hj2pHaxTMZtACZdn+RJT0hsVFxz71Xk/TAULAQRA=; b=iG5GAyxM6YTV8mcKvlN9oefJeS+CB12O+hyMSxM63ZP+XEAzsdcXiQqxDpiN/5i6pc XRD0lb+z4j2MBjUMKnjEyqexm6C1gNI4SxrH50j7Ug6sB9KX15R7/sjAfZfHiBKR455A Z9jCchg/ltNM+awwvdTDMNcqK46IS468x4fdUrP7BVZVcEv/B3xuI/zhZEETIQan2WaA QCfoCXxIWfuRjMrHO3MpgZHGUFuaFHmth1pRkaq9uIXBWnZYNGesAJvAGrD1IFdVeFFq qPa8v8lcT3T0R6bWPqnlKp2vsfMnqJwwUw/kUhWH0lkdUOfYfacd4tFptGclUVFg07Kn evGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xt0hj2pHaxTMZtACZdn+RJT0hsVFxz71Xk/TAULAQRA=; b=e4C3buJhqU3hbfHX/Rpb9yfSWWN/j1bXhTO/3j+lZpcf+VtEynSmDck3jyfVifyEt7 V/YB3Va84/rhCQGot173na6crx7azDaqN0ubHV3jRN+1RbaFu115tn8hGRTpaQMWfzfq i9ySlSp7MK3ahJt6sEtPX7DUoAF/TFb2Qhy5BxhYRrQRh1GCOBm/cFjpEVHxVB87kT6O xhwALRnHAZ3AY7s7mVG1eB2b4gpcpDyvlpDxnvchK3MFE7HIiGKBQPwtfYzxWR+AFCLL wKFU1wYdEjk4oRXUuz31u9WQQJBOcYDDewqtbFUf+upDTTTpQ3I2t/xMIHOmIeZz5zWt ZWiQ== X-Gm-Message-State: APjAAAVoBhq8P3NWjr83XqQT5O8lRXadfbik6YLq+O/TLwemtevujVLq uIZkA5hBNbkqNYXnrqm2AkI= X-Google-Smtp-Source: APXvYqwIn77W5Yh+i6fUqF3tZ4FD3A6SD47qiW6TNwO2kiimWYNsaxlrGj8XNf1c5AwapCGS+Chg+g== X-Received: by 2002:a65:5b44:: with SMTP id y4mr20269542pgr.446.1553738706986; Wed, 27 Mar 2019 19:05:06 -0700 (PDT) Received: from ?IPv6:2601:284:8200:5cfb:3c44:c5bd:e28a:98ee? ([2601:284:8200:5cfb:3c44:c5bd:e28a:98ee]) by smtp.googlemail.com with ESMTPSA id j20sm42360721pfi.27.2019.03.27.19.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 19:05:05 -0700 (PDT) Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh To: Alexei Starovoitov Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com References: <20190327182329.18149-1-dsahern@kernel.org> <20190327182329.18149-6-dsahern@kernel.org> <20190327225210.kbpivej33a72adwq@ast-mbp> <8e0e2afc-c8e7-8728-7b4d-f9c64987d46a@gmail.com> <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> From: David Ahern Message-ID: <51a3d3fa-e0c1-ca40-8c25-659487a092f7@gmail.com> Date: Wed, 27 Mar 2019 20:05:03 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/27/19 7:30 PM, Alexei Starovoitov wrote: >>> >>> imo it would be cleaner not to mess with cfg. >>> Ideally it should be marked 'const'. >> >> Existing code sets those flags but on a fib6_info. This is not used for >> nexthop objects and is kept here to not duplicate this if branch in the >> create_info that uses it. This check affects both which device is used >> as well as the flags. > > What stopping you from doing fib6_nh->nh_flags |= RTF_REJECT | RTF_NONEXTHOP ? > cfg should really be const. Because it is not a nexthop flag, it is a prefix flag. >>> >>> lwtstate_put() is missing in the error path of existing code. >>> Is this a bug fix? >>> Why there is nothing about this in commit log? >> >> Existing code has a different cleanup path. >> >> This is done explicitly here per a request from Ido in v1 that the new >> function be symmetric in its cleanup on an error. > > I saw that comment. > What I don't see is where existing code doing that cleanup. > Could you please point it out? fib6_info_release -> fib6_info_destroy_rcu