From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F2CC12002 for ; Wed, 14 Jul 2021 20:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82D63613D2 for ; Wed, 14 Jul 2021 20:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbhGNU5v convert rfc822-to-8bit (ORCPT ); Wed, 14 Jul 2021 16:57:51 -0400 Received: from mga06.intel.com ([134.134.136.31]:43572 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbhGNU5u (ORCPT ); Wed, 14 Jul 2021 16:57:50 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="271537028" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="271537028" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 13:54:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="562561073" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 14 Jul 2021 13:54:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 14 Jul 2021 13:54:57 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 14 Jul 2021 13:54:57 -0700 Received: from orsmsx610.amr.corp.intel.com ([10.22.229.23]) by ORSMSX610.amr.corp.intel.com ([10.22.229.23]) with mapi id 15.01.2242.010; Wed, 14 Jul 2021 13:54:57 -0700 From: "Keller, Jacob E" To: Andrew Lunn CC: "netdev@vger.kernel.org" , Jakub Kicinski , Jiri Pirko Subject: RE: [PATCH net-next RFC] devlink: add commands to query flash and reload support Thread-Topic: [PATCH net-next RFC] devlink: add commands to query flash and reload support Thread-Index: AQHXeOf8manj9a07IkKwIDHDT9TX46tDYGaA//+SLpA= Date: Wed, 14 Jul 2021 20:54:56 +0000 Message-ID: <51a6e7a33c7d40889c80bf37159f210e@intel.com> References: <20210714193918.1151083-1-jacob.e.keller@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Andrew Lunn > Sent: Wednesday, July 14, 2021 1:26 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Jakub Kicinski ; Jiri Pirko > > Subject: Re: [PATCH net-next RFC] devlink: add commands to query flash and > reload support > > > I'm not sure if this is the best direction to go for implementing this. > > Hi Jacob > > Maybe add a --dry-run option? That would allow the driver to also read > the firmware file, make sure it can parse it, it fits the actual > hardware, and the CRC is O.K, etc. > > We just need to make sure that if it fails with -EOPNOTSUPP, is it > clear if --dry-run itself is not supported, or the operation is not > supported. extack should help with that. > > Andrew That approach could be useful. It doesn't give an easy way to dump all of the supported flags, but that's not super critical. I think a dry-run makes a lot of sense for flash update. I can go that approach for these two and see how it turns out. Thanks, Jake