From: Hau <hau@realtek.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: nic_swsd <nic_swsd@realtek.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH net v3 1/2] r8169: add handling DASH when DASH is disabled
Date: Thu, 9 Nov 2023 17:29:43 +0000 [thread overview]
Message-ID: <51b3bbff47ff4e8dafeaeff647979d4e@realtek.com> (raw)
In-Reply-To: <a1f703f4-a0da-4f88-9c1c-e5f6b6e2ce50@gmail.com>
> > if (!netif_running(tp->dev) || !netif_carrier_ok(tp->dev)) @@
> > -4896,7 +4909,7 @@ static void rtl_shutdown(struct pci_dev *pdev)
> > rtl_rar_set(tp, tp->dev->perm_addr);
> >
> > if (system_state == SYSTEM_POWER_OFF &&
> > - tp->dash_type == RTL_DASH_NONE) {
> > + !tp->dash_enabled) {
>
> Why break the line at all? Now the check fits the 80 char line limit.
I will correct this. Thanks.
next prev parent reply other threads:[~2023-11-09 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 16:43 [PATCH net v3 0/2] r8169: fix DASH devices network lost issue ChunHao Lin
2023-11-09 16:43 ` [PATCH net v3 1/2] r8169: add handling DASH when DASH is disabled ChunHao Lin
2023-11-09 17:14 ` Heiner Kallweit
2023-11-09 17:29 ` Hau [this message]
2023-11-09 16:43 ` [PATCH net v3 2/2] r8169: fix network lost after resume on DASH systems ChunHao Lin
2023-11-09 17:15 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b3bbff47ff4e8dafeaeff647979d4e@realtek.com \
--to=hau@realtek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).