From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net v2] ipv6: set all.accept_dad to 0 by default Date: Wed, 15 Nov 2017 11:17:28 +0100 Message-ID: <51c016c1-800b-3860-71df-ac77b8faa8f6@6wind.com> References: <20171114032403.11ed517e@elisabeth> <20171114132132.25833-1-nicolas.dichtel@6wind.com> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, Stefano Brivio , Matteo Croce , Erik Kline To: davem@davemloft.net Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:42825 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbdKOKR0 (ORCPT ); Wed, 15 Nov 2017 05:17:26 -0500 Received: by mail-wm0-f42.google.com with SMTP id t139so1882972wmt.1 for ; Wed, 15 Nov 2017 02:17:25 -0800 (PST) In-Reply-To: <20171114132132.25833-1-nicolas.dichtel@6wind.com> Content-Language: fr Sender: netdev-owner@vger.kernel.org List-ID: Le 14/11/2017 à 14:21, Nicolas Dichtel a écrit : > With commits 35e015e1f577 and a2d3f3e33853, the global 'accept_dad' flag > is also taken into account (default value is 1). If either global or > per-interface flag is non-zero, DAD will be enabled on a given interface. > > This is not backward compatible: before those patches, the user could > disable DAD just by setting the per-interface flag to 0. Now, the > user instead needs to set both flags to 0 to actually disable DAD. > > Restore the previous behaviour by setting the default for the global > 'accept_dad' flag to 0. This way, DAD is still enabled by default, > as per-interface flags are set to 1 on device creation, but setting > them to 0 is enough to disable DAD on a given interface. > > - Before 35e015e1f57a7 and a2d3f3e33853: > global per-interface DAD enabled > [default] 1 1 yes > X 0 no > X 1 yes > > - After 35e015e1f577 and a2d3f3e33853: > global per-interface DAD enabled > [default] 1 1 yes > 0 0 no > 0 1 yes > 1 0 yes > > - After this fix: > global per-interface DAD enabled > 1 1 yes > 0 0 no > [default] 0 1 yes > 1 0 yes > > Fixes: 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers") > Fixes: a2d3f3e33853 ("ipv6: fix net.ipv6.conf.all.accept_dad behaviour for real") > CC: Stefano Brivio > CC: Matteo Croce > CC: Erik Kline > Signed-off-by: Nicolas Dichtel David, I saw that you pushed this patch in net-next instead of net. Is it intentional? I was expecting to see it in net, to fix the 4.14. Thank you, Nicolas