From: Sergio Callegari <sergio.callegari@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
netdev@vger.kernel.org,
Linux Kernel Mailing list <linux-kernel@vger.kernel.org>,
Linux Regressions <regressions@lists.linux.dev>,
Oliver Neukum <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Regression with AX88179A: can't manually set MAC address anymore
Date: Thu, 7 Sep 2023 08:56:42 +0200 [thread overview]
Message-ID: <51c98bc8-b9df-4cd8-adf8-55c1f2790b08@gmail.com> (raw)
In-Reply-To: <d6777bc1-46ad-4ad9-a7e3-655dbe4f6317@lunn.ch>
For the time being having AX88179A error out on attempts to set an
hardware address would possibly be useful, though.
Sergio
On 06/09/2023 14:31, Andrew Lunn wrote:
>> So if the in-tree driver could be fixed to correctly support the manual
>> configuration of the hardware (MAC) address as it used to be that would be
>> the best. I hope that Andrew Lunn's hypothesis is correct, and that cdc_ncm
>> can be extended to work with AX88179A even when a manual MAC addr is
>> configured.
> I think it can, but it looks like it needs a different
> implementation. The CDC NCM standard is publicly available. It
> documents an optional call to set the MAC address, and there appears
> to be a capability bit to indicate if its implemented in a specific
> device. Ideally if the bit is not set -EOPNOTSUPP should be returned
> when trying to set the MAC address, otherwise make the call to let the
> hardware know of the new MAC address.
>
> Sorry, i don't have the time or the hardware to actually implement
> this. But i can review patches and help with processes.
>
> Andrew
>
>
next prev parent reply other threads:[~2023-09-07 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 11:02 Regression with AX88179A: can't manually set MAC address anymore Sergio Callegari
2023-09-05 12:31 ` Bagas Sanjaya
2023-09-05 20:11 ` Sergio Callegari
[not found] ` <6315027e-d1ab-4dec-acf2-0a77bb948807@gmail.com>
2023-09-06 1:43 ` Bagas Sanjaya
2023-09-06 11:37 ` Sergio Callegari
2023-09-06 12:31 ` Andrew Lunn
2023-09-07 6:56 ` Sergio Callegari [this message]
2023-09-05 20:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c98bc8-b9df-4cd8-adf8-55c1f2790b08@gmail.com \
--to=sergio.callegari@gmail.com \
--cc=andrew@lunn.ch \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).