From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C5F4F7CB2 for ; Mon, 12 Oct 2026 21:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791840555; cv=none; b=aZoJptKPpMd1kPOPYrnVkRxB20f4V50Ng6yqrhz4F0eoOYrt6J8SatmahJZWKAIdqGo1McB6GENwDaUD95fOWmVerebxTrBoxHiVelP0myggrSwmkbmTsyj+dws3p5VurtsTcdhqgUeSTT/36LFaIOIvwFvGr7hTEZIRKThgnuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791840555; c=relaxed/simple; bh=tzs5CD2tSnlyGalWGG9z7ThJaIEC0CKx/vNEZpG175o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EseQkSrQeTz8emUM+xnLb0WdqdJ/kIikRM0xx2OKojwR9KknPjwT50843oDip5hTpx5cDNh2RvB4lZ1KSWOcIHqL/muHF3me9Hh66Tq9dMu+KtQ+AOG6yCJ3ggjiOpdXOq47/s0OyRai5ykuxdl9eLwoPmiqi7xCuCxVZvMSPBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=TYnwhXav; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TYnwhXav" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-3ab2bf5e75bso1148371a91.3 for ; Mon, 12 Oct 2026 14:29:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791840553; x=1792445353; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=jv8RLmh+BBN7OwXpsRNHyPmSqTvyEIgD1ZiumdDwpGs=; b=SWhRKwXLkaUS9KT5CSvExMpyE3a+bB0gXloNjZ5SiMvwRCKnjVl6BIiOFz2ueXjzyK BncvNLyp4sBTV5QymOAb3SEgdjcDxtq7bDoSXIpICqvp+Qdd6VHncp/EDQr+HB/Y+k3/ B7elZQuTOGJQA/6ny6wdW95SEdMpm8JMO7tNej2LzoeLjfqKs4w8f/mnl9b0BDfl8P4Q bBb7aT5HXD/0LKtXKqmgFUqxfp1+CYj/NdZjwRi2v7cLFQDB2K1oW+hRS1AbNaWJEURz gfUQXSCHh6kLQttx4IOrXDixAPiZWV+auG4o0wNKW3HS6Gi0O7nuB2k1uJAgTxVRP0Pg eTNg== X-Gm-Message-State: AFq9FYK/ssJ7Vmcbll2whnbQ8+UWC4hFjs3uL2g53IvkqO2kq/Fn3b2N +/kAYA/xlt6yOBe+DC9Yx+we0V7EEaRsTYqcsk32L43M4u9itAAdcdotqp/HfSWQWAjjEOF0qJs rSHACYZq1U6YkJCSCSFvokeD4dIwbtSe7U+aKDHHggEvLsa4YG/uBTqJSLiDDFRj92GZtjIJhPq hjYGd5KRdF/hMauWxmET00o6/iCYppZMS8NhEYp8vH5wFfvpa0ONaHuhHsKm93CuVm5w/N7jRJ4 rIOWwBo4z4i/3me X-Gm-Gg: AYBFou3gtKtQ/dKpIKsQpgddhBVUPPH5/yEmA1mHjfssgMWgHXWgsXgvfXAzJ7jotBn I7fKweHY8f0381bsknHzq7RTZWMoV6/6uqFi8q/TB7MRFmjoCoTRbxJkiYPbtlKLuxFrrfUxdsS OXXDNrzCbGMGWuCwst/k9JbSwQdFSt8sFb47WhOto4yXP0vSWowACV8LiwHP3sNPw2fMYrnFsQP uYlMmhNM3EFH2IRl5inP9m9RGxmZckqwGcXW+UvSlGWbtF/9iTccAmU0YPYfxvogA21j9rFfWP9 wkoGREX0g9usYzQYNXNgebFv2mL5LZDFVhfzeKcReRVuNqPD+3gl0vujc9JLCmPeDzgJq5iIctV i6gFttQvTpOUSVzsae0dbFSysNu/8O/DEk2wtwHn9AZCHP4uUK0M6u/LXlj5OScdoKLxb6z8waC MQKf6Gv9pRox0fg85deqeAzUk6iem++hoV6qigMD7UCr0= X-Received: by 2002:a17:90a:a96:b0:3ab:b764:826c with SMTP id 98e67ed59e1d1-3abb7649d07mr3324666a91.12.1791840553307; Mon, 12 Oct 2026 14:29:13 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3ab37a4a652sm6205368a91.5.2026.10.12.14.29.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2026 14:29:13 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-3515266f6eeso4365113eec.0 for ; Mon, 12 Oct 2026 14:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1791840552; x=1792445352; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jv8RLmh+BBN7OwXpsRNHyPmSqTvyEIgD1ZiumdDwpGs=; b=TYnwhXav+C7p/8q0OQJtuY420KnJ+aHb4exs1XsQc5QOFDSvdLK01J4lnBj2W5qBvE FMsxfuu6ODsZJ03HBscfxu2SwlNUBEy8flX4GpX6xz5qiP4xMacwxl3G4C7mc5fkVi2e ZQ3S83HbhpW2ZjPIiV7jZ+wdiknQSHClx1c04= X-Received: by 2002:a05:7301:fd8a:b0:351:5151:95d9 with SMTP id 5a478bee46e88-3537de0069emr13002132eec.3.1791840551612; Mon, 12 Oct 2026 14:29:11 -0700 (PDT) X-Received: by 2002:a05:7301:fd8a:b0:351:5151:95d9 with SMTP id 5a478bee46e88-3537de0069emr13002027eec.3.1791840549169; Mon, 12 Oct 2026 14:29:09 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb2fd33sm35639959eec.28.2026.10.12.14.29.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 14:29:08 -0700 (PDT) Message-ID: <51db5a29-c3c0-429b-b067-8762e683a8ef@broadcom.com> Date: Mon, 12 Oct 2026 14:29:06 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 1/8] net: bcmgenet: ring the doorbell when the last frame of a batch is dropped To: Nicolai Buchwitz , Doug Berger , Broadcom internal kernel review list , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Stevenson , Justin Chen , Pierre-Marin Leclercq , Florian Fainelli References: <20261012-nb-genet-mtu-nn-v2-v4-0-2e2e3bfaf8cc@tipi-net.de> <20261012-nb-genet-mtu-nn-v2-v4-1-2e2e3bfaf8cc@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20261012-nb-genet-mtu-nn-v2-v4-1-2e2e3bfaf8cc@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/12/26 02:00, Nicolai Buchwitz wrote: > bcmgenet_xmit() only writes the producer index at the end of a batch. The > error exits return before that write. If the dropped frame was the last of > an xmit_more batch, the frames queued before it stay in the ring until the > next transmit. The queue is still running, so the watchdog does not fire. > > Found by a sashiko review, not by a bug report. The existing exits only > trigger on an allocation or DMA mapping failure, and the padding in a later > patch adds three more. > > Write the producer index on those exits too. > > Fixes: ddd0ca5d60b3 ("net: bcmgenet: add support for xmit_more") > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli -- Florian