From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next v2 3/8] r8169: initialize task workqueue only once
Date: Sat, 19 Jan 2019 22:03:49 +0100 [thread overview]
Message-ID: <51e77c84-2ddc-d883-89ee-2826fdccb533@gmail.com> (raw)
In-Reply-To: <efa9d921-1190-62b9-4515-b38d7f5564cd@gmail.com>
It's sufficient to initialize the workqueue once, therefore remove the
additional initialization whenever rtl_open() is called.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index fd3c6a548..c4d53bc6a 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -6630,10 +6630,6 @@ static int rtl_open(struct net_device *dev)
if (retval < 0)
goto err_free_rx_1;
- INIT_WORK(&tp->wk.work, rtl_task);
-
- smp_mb();
-
rtl_request_firmware(tp);
retval = pci_request_irq(pdev, 0, rtl8169_interrupt, NULL, tp,
@@ -7293,6 +7289,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
tp->saved_wolopts = __rtl8169_get_wol(tp);
mutex_init(&tp->wk.mutex);
+ INIT_WORK(&tp->wk.work, rtl_task);
u64_stats_init(&tp->rx_stats.syncp);
u64_stats_init(&tp->tx_stats.syncp);
--
2.20.1
next prev parent reply other threads:[~2019-01-19 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 21:01 [PATCH net-next v2 0/8] r8169: series with smaller improvements Heiner Kallweit
2019-01-19 21:02 ` [PATCH net-next v2 1/8] r8169: remove rtl_get_events Heiner Kallweit
2019-01-19 21:03 ` [PATCH net-next v2 2/8] r8169: remove unneeded call in pcierr Heiner Kallweit
2019-01-19 21:03 ` Heiner Kallweit [this message]
2019-01-19 21:05 ` [PATCH net-next v2 4/8] r8169: improve rtl_pcie_state_l2l3_enable Heiner Kallweit
2019-01-19 21:05 ` [PATCH net-next v2 5/8] r8169: add helpers for locking / unlocking the config registers Heiner Kallweit
2019-01-19 21:06 ` [PATCH net-next v2 6/8] r8169: reset chip synchronously in __rtl8169_resume Heiner Kallweit
2019-01-19 21:07 ` [PATCH net-next v2 7/8] r8169: replace mii_bus member with phy_device member in struct rtl8169_private Heiner Kallweit
2019-01-19 21:07 ` [PATCH net-next v2 8/8] r8169: factor out getting ether_clk Heiner Kallweit
2019-01-20 0:09 ` [PATCH net-next v2 0/8] r8169: series with smaller improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51e77c84-2ddc-d883-89ee-2826fdccb533@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).