From: Ilya Maximets <i.maximets@ovn.org>
To: netdev-bot+sashiko@kernel.org, i.maximets@ovn.org
Cc: netdev@vger.kernel.org, pablo@netfilter.org, fw@strlen.de,
phil@nwl.cc, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
aconole@redhat.com, echaudro@redhat.com, jhs@mojatatu.com,
jiri@resnulli.us, lucien.xin@gmail.com,
marcelo.leitner@gmail.com, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
dev@openvswitch.org, stable@vger.kernel.org
Subject: Re: [PATCH net 3/6] net: openvswitch: conntrack: fix helper UAF due to extensions realloc
Date: Tue, 22 Sep 2026 17:43:18 +0200 [thread overview]
Message-ID: <51f0cbae-71e3-4b9f-af91-55a610eb15d0@ovn.org> (raw)
In-Reply-To: <179008911935.2160803.14933035266780079917@kernel.org>
On 9/22/26 4:58 PM, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
>
> - [Low] Inaccurate newly added comment in __ovs_ct_lookup()
> (net/openvswitch/conntrack.c:820-826).
Same thing as for the previous patch. Comments do not need to
spell out everything that happens in the code. The intention of
the comment and the code seems clear enough to me. So, I'd keep
it as-is, unless someone thinks it needs more clarification.
>
> Pre-existing issues:
> - [Low] Concern (INVALIDATED by later patch in the same series): the
> identical helper/expectation use-after-free was claimed to remain…
Preexisting and fixed later in the set.
Best regards, Ilya Maximets.
next prev parent reply other threads:[~2026-09-22 15:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 14:55 [PATCH net 0/6] ovs, net/sched: fixes for UAF after conntrack extension realloc Ilya Maximets
2026-09-21 14:55 ` [PATCH net 1/6] net: openvswitch: conntrack: avoid modifying shared unconfirmed ct entry Ilya Maximets
2026-09-22 14:58 ` netdev-bot+sashiko
2026-09-22 15:27 ` Ilya Maximets
2026-09-22 15:26 ` Aaron Conole
2026-09-21 14:55 ` [PATCH net 2/6] net: openvswitch: conntrack: remove 'add_helper' dead code Ilya Maximets
2026-09-22 14:58 ` netdev-bot+sashiko
2026-09-22 15:29 ` Ilya Maximets
2026-09-22 15:26 ` Aaron Conole
2026-09-21 14:55 ` [PATCH net 3/6] net: openvswitch: conntrack: fix helper UAF due to extensions realloc Ilya Maximets
2026-09-22 14:58 ` netdev-bot+sashiko
2026-09-22 15:43 ` Ilya Maximets [this message]
2026-09-22 15:26 ` Aaron Conole
2026-09-21 14:55 ` [PATCH net 4/6] net/sched: act_ct: avoid modifying shared unconfirmed ct entry Ilya Maximets
2026-09-22 14:58 ` netdev-bot+sashiko
2026-09-22 15:52 ` Ilya Maximets
2026-09-22 15:27 ` Aaron Conole
2026-09-22 20:42 ` Xin Long
2026-09-22 21:34 ` Jamal Hadi Salim
2026-09-21 14:55 ` [PATCH net 5/6] net/sched: act_ct: remove 'add_helper' dead code Ilya Maximets
2026-09-22 15:27 ` Aaron Conole
2026-09-22 20:43 ` Xin Long
2026-09-22 21:35 ` Jamal Hadi Salim
2026-09-21 14:55 ` [PATCH net 6/6] net/sched: act_ct: fix helper UAF due to extensions realloc Ilya Maximets
2026-09-22 14:58 ` netdev-bot+sashiko
2026-09-22 15:54 ` Ilya Maximets
2026-09-22 20:43 ` Xin Long
2026-09-22 21:36 ` Jamal Hadi Salim
2026-09-23 12:35 ` Aaron Conole
2026-09-24 1:21 ` [PATCH net 0/6] ovs, net/sched: fixes for UAF after conntrack extension realloc Jakub Kicinski
2026-09-24 17:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f0cbae-71e3-4b9f-af91-55a610eb15d0@ovn.org \
--to=i.maximets@ovn.org \
--cc=aconole@redhat.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox