public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* Preferred method for configuration
@ 2013-08-08  5:32 Thomas Martitz
  2013-08-08  5:41 ` Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Martitz @ 2013-08-08  5:32 UTC (permalink / raw)
  To: netdev@vger.kernel.org

Hello,

I'm developing a NIC driver and currently export some custom 
configuration settings and actions (e.g. enabling a loopback mode) via 
sysfs. However I read about ioctl() and configfs and am now confused as 
to what the preferred/expected method is for new drivers.

Best regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Preferred method for configuration
  2013-08-08  5:32 Preferred method for configuration Thomas Martitz
@ 2013-08-08  5:41 ` Joe Perches
  2013-08-08  5:56   ` Thomas Martitz
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2013-08-08  5:41 UTC (permalink / raw)
  To: Thomas Martitz; +Cc: netdev@vger.kernel.org

On Thu, 2013-08-08 at 07:32 +0200, Thomas Martitz wrote:
> Hello,
> 
> I'm developing a NIC driver and currently export some custom 
> configuration settings and actions (e.g. enabling a loopback mode) via 
> sysfs.

Is there some reason you don't want to use ethtool?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Preferred method for configuration
  2013-08-08  5:41 ` Joe Perches
@ 2013-08-08  5:56   ` Thomas Martitz
  2013-08-08  9:44     ` Ben Hutchings
  2013-08-08 16:01     ` Stephen Hemminger
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Martitz @ 2013-08-08  5:56 UTC (permalink / raw)
  To: Joe Perches; +Cc: netdev@vger.kernel.org

Resent with list in CC.

Am 08.08.2013 07:41, schrieb Joe Perches:
> On Thu, 2013-08-08 at 07:32 +0200, Thomas Martitz wrote:
>> Hello,
>>
>> I'm developing a NIC driver and currently export some custom
>> configuration settings and actions (e.g. enabling a loopback mode) via
>> sysfs.
>
> Is there some reason you don't want to use ethtool?
>
>

It doesn't allow for custom settings does it? For standards stuff I'm 
sure going to use ethtool.

Best regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Preferred method for configuration
  2013-08-08  5:56   ` Thomas Martitz
@ 2013-08-08  9:44     ` Ben Hutchings
  2013-08-08 16:01     ` Stephen Hemminger
  1 sibling, 0 replies; 6+ messages in thread
From: Ben Hutchings @ 2013-08-08  9:44 UTC (permalink / raw)
  To: Thomas Martitz; +Cc: Joe Perches, netdev@vger.kernel.org

On Thu, 2013-08-08 at 07:56 +0200, Thomas Martitz wrote:
> Resent with list in CC.
> 
> Am 08.08.2013 07:41, schrieb Joe Perches:
> > On Thu, 2013-08-08 at 07:32 +0200, Thomas Martitz wrote:
> >> Hello,
> >>
> >> I'm developing a NIC driver and currently export some custom
> >> configuration settings and actions (e.g. enabling a loopback mode) via
> >> sysfs.
> >
> > Is there some reason you don't want to use ethtool?
> >
> >
> 
> It doesn't allow for custom settings does it? For standards stuff I'm 
> sure going to use ethtool.

You can always propose extensions to ethtool.

Note that the ethtool 'features' API already allows setting loopback and
there is a 'private flags' API through which you can expose up to 32
arbitrary named flags if they're really not at all generic.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Preferred method for configuration
  2013-08-08  5:56   ` Thomas Martitz
  2013-08-08  9:44     ` Ben Hutchings
@ 2013-08-08 16:01     ` Stephen Hemminger
  2013-08-13 12:13       ` Thomas Martitz
  1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2013-08-08 16:01 UTC (permalink / raw)
  To: Thomas Martitz; +Cc: Joe Perches, netdev@vger.kernel.org

On Thu, 08 Aug 2013 07:56:04 +0200
Thomas Martitz <thomas.martitz@hhi.fraunhofer.de> wrote:

> Resent with list in CC.
> 
> Am 08.08.2013 07:41, schrieb Joe Perches:
> > On Thu, 2013-08-08 at 07:32 +0200, Thomas Martitz wrote:
> >> Hello,
> >>
> >> I'm developing a NIC driver and currently export some custom
> >> configuration settings and actions (e.g. enabling a loopback mode) via
> >> sysfs.
> >
> > Is there some reason you don't want to use ethtool?
> >
> >
> 
> It doesn't allow for custom settings does it? For standards stuff I'm 
> sure going to use ethtool.

Any feature "special to my driver" is sure to meet stiff resistance
from the kernel developers. Special features make it impossible for generic
configuration in distributions and by management layers.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Preferred method for configuration
  2013-08-08 16:01     ` Stephen Hemminger
@ 2013-08-13 12:13       ` Thomas Martitz
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Martitz @ 2013-08-13 12:13 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev@vger.kernel.org

Am 08.08.2013 18:01, schrieb Stephen Hemminger:
> On Thu, 08 Aug 2013 07:56:04 +0200
> Thomas Martitz <thomas.martitz@hhi.fraunhofer.de> wrote:
>
>> Resent with list in CC.
>>
>> Am 08.08.2013 07:41, schrieb Joe Perches:
>>> On Thu, 2013-08-08 at 07:32 +0200, Thomas Martitz wrote:
>>>> Hello,
>>>>
>>>> I'm developing a NIC driver and currently export some custom
>>>> configuration settings and actions (e.g. enabling a loopback mode) via
>>>> sysfs.
>>>
>>> Is there some reason you don't want to use ethtool?
>>>
>>>
>>
>> It doesn't allow for custom settings does it? For standards stuff I'm
>> sure going to use ethtool.
>
> Any feature "special to my driver" is sure to meet stiff resistance
> from the kernel developers. Special features make it impossible for generic
> configuration in distributions and by management layers.
>

What about features that are really unique to the device?

Best regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-08-13 12:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08  5:32 Preferred method for configuration Thomas Martitz
2013-08-08  5:41 ` Joe Perches
2013-08-08  5:56   ` Thomas Martitz
2013-08-08  9:44     ` Ben Hutchings
2013-08-08 16:01     ` Stephen Hemminger
2013-08-13 12:13       ` Thomas Martitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox