netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ding Tianhong <dingtianhong@huawei.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
	Allan Stephens <allan.stephens@windriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Netdev <netdev@vger.kernel.org>,
	<tipc-discussion@lists.sourceforge.net>
Subject: [PATCH 0/2] avoid possible deadlock while enable and disable bearer
Date: Thu, 8 Aug 2013 18:45:01 +0800	[thread overview]
Message-ID: <520376AD.7080404@huawei.com> (raw)

It will occur two deadlock warming When run the command such as:

tipc-config -netid=1234 -addr=1.1.3 -be=eth:eth0
tipc-config -netid=1234 -addr=1.1.3 -bd=eth:eth0

The reason is that the tipc_link_delete() will cancel the link_timeout() and
disc_timeout() when disable the bearer, the xxx_timeout() will require b_ptr->lock,
but the b_ptr->lock is already hold, so the deadlock will occur.

We need to unlock the b_ptr->lock when calling xxx_timeout().

Ding Tianhong (1):
  tipc: avoid possible deadlock while remove link_timeout()

Wang Weidong (1):
  tipc: avoid possible deadlock while remove disc_timeout()

 net/tipc/bearer.c | 14 ++++++++++----
 net/tipc/link.c   |  2 ++
 2 files changed, 12 insertions(+), 4 deletions(-)

-- 
1.8.2.1

                 reply	other threads:[~2013-08-08 10:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520376AD.7080404@huawei.com \
    --to=dingtianhong@huawei.com \
    --cc=allan.stephens@windriver.com \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).