From: Ding Tianhong <dingtianhong@huawei.com>
To: Ying Xue <ying.xue@windriver.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>,
Allan Stephens <allan.stephens@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
<tipc-discussion@lists.sourceforge.net>
Subject: Re: [PATCH 1/2] tipc: avoid possible deadlock while remove link_timeout()
Date: Fri, 9 Aug 2013 11:38:07 +0800 [thread overview]
Message-ID: <5204641F.60009@huawei.com> (raw)
In-Reply-To: <5204567E.2050805@windriver.com>
On 2013/8/9 10:39, Ying Xue wrote:
> On 08/08/2013 06:45 PM, Ding Tianhong wrote:
>>
>> The problem is that the tipc_link_delete() will cancel the timer l_ptr->timer when
>> the b_ptr->lock is hold, but the l_ptr->timer still call b_ptr->lock to finish the
>> work, so the dead lock occurs.
>>
>
> I guess the issue would disappear if you apply below patch:
>
> http://article.gmane.org/gmane.network.tipc.general/4380
>
> And the patch will be submitted into net-next tree soon.
>
> Regards,
> Ying
>
yes, I test the patch and fix the 1/2 problem, but the 2/2 problem still occurs, if
the http://article.gmane.org/gmane.network.tipc.general/4380 and queue for stable, I will resend
2/2 patch again and cancel the 1/2 patch.
next prev parent reply other threads:[~2013-08-09 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 10:45 [PATCH 1/2] tipc: avoid possible deadlock while remove link_timeout() Ding Tianhong
2013-08-09 2:39 ` Ying Xue
2013-08-09 3:38 ` Ding Tianhong [this message]
2013-08-09 4:36 ` Ying Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204641F.60009@huawei.com \
--to=dingtianhong@huawei.com \
--cc=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).