* [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state
@ 2013-08-09 13:09 Daniel Borkmann
2013-08-09 13:39 ` Vlad Yasevich
2013-08-11 16:16 ` Neil Horman
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Borkmann @ 2013-08-09 13:09 UTC (permalink / raw)
To: davem; +Cc: kheiss, netdev, linux-sctp, Neil Horman
The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd
should be 1 MTU. So, instead of 1, set it to 1 MTU.
[1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
Reported-by: Karl Heiss <kheiss@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
---
net/sctp/associola.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index bce5b79..ab67efc 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
else
spc_state = SCTP_ADDR_AVAILABLE;
/* Don't inform ULP about transition from PF to
- * active state and set cwnd to 1, see SCTP
+ * active state and set cwnd to 1 MTU, see SCTP
* Quick failover draft section 5.1, point 5
*/
if (transport->state == SCTP_PF) {
ulp_notify = false;
- transport->cwnd = 1;
+ transport->cwnd = asoc->pathmtu;
}
transport->state = SCTP_ACTIVE;
break;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state
2013-08-09 13:09 [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Daniel Borkmann
@ 2013-08-09 13:39 ` Vlad Yasevich
2013-08-13 5:12 ` David Miller
2013-08-11 16:16 ` Neil Horman
1 sibling, 1 reply; 4+ messages in thread
From: Vlad Yasevich @ 2013-08-09 13:39 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: davem, kheiss, netdev, linux-sctp, Neil Horman
On 08/09/2013 09:09 AM, Daniel Borkmann wrote:
> The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd
> should be 1 MTU. So, instead of 1, set it to 1 MTU.
>
> [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>
> Reported-by: Karl Heiss <kheiss@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> Cc: Neil Horman <nhorman@tuxdriver.com>
> ---
> net/sctp/associola.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index bce5b79..ab67efc 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
> else
> spc_state = SCTP_ADDR_AVAILABLE;
> /* Don't inform ULP about transition from PF to
> - * active state and set cwnd to 1, see SCTP
> + * active state and set cwnd to 1 MTU, see SCTP
> * Quick failover draft section 5.1, point 5
> */
> if (transport->state == SCTP_PF) {
> ulp_notify = false;
> - transport->cwnd = 1;
> + transport->cwnd = asoc->pathmtu;
> }
> transport->state = SCTP_ACTIVE;
> break;
>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
-vlad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state
2013-08-09 13:39 ` Vlad Yasevich
@ 2013-08-13 5:12 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-08-13 5:12 UTC (permalink / raw)
To: vyasevich; +Cc: dborkman, kheiss, netdev, linux-sctp, nhorman
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Fri, 09 Aug 2013 09:39:45 -0400
> On 08/09/2013 09:09 AM, Daniel Borkmann wrote:
>> The SCTP Quick failover draft [1] section 5.1, point 5 says that the
>> cwnd
>> should be 1 MTU. So, instead of 1, set it to 1 MTU.
>>
>> [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>>
>> Reported-by: Karl Heiss <kheiss@gmail.com>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> Cc: Neil Horman <nhorman@tuxdriver.com>
...
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state
2013-08-09 13:09 [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Daniel Borkmann
2013-08-09 13:39 ` Vlad Yasevich
@ 2013-08-11 16:16 ` Neil Horman
1 sibling, 0 replies; 4+ messages in thread
From: Neil Horman @ 2013-08-11 16:16 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: davem, kheiss, netdev, linux-sctp
On Fri, Aug 09, 2013 at 03:09:08PM +0200, Daniel Borkmann wrote:
> The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd
> should be 1 MTU. So, instead of 1, set it to 1 MTU.
>
> [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>
> Reported-by: Karl Heiss <kheiss@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> Cc: Neil Horman <nhorman@tuxdriver.com>
> ---
> net/sctp/associola.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index bce5b79..ab67efc 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
> else
> spc_state = SCTP_ADDR_AVAILABLE;
> /* Don't inform ULP about transition from PF to
> - * active state and set cwnd to 1, see SCTP
> + * active state and set cwnd to 1 MTU, see SCTP
> * Quick failover draft section 5.1, point 5
> */
> if (transport->state == SCTP_PF) {
> ulp_notify = false;
> - transport->cwnd = 1;
> + transport->cwnd = asoc->pathmtu;
> }
> transport->state = SCTP_ACTIVE;
> break;
> --
> 1.7.11.7
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-13 5:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 13:09 [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Daniel Borkmann
2013-08-09 13:39 ` Vlad Yasevich
2013-08-13 5:12 ` David Miller
2013-08-11 16:16 ` Neil Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).