From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: davem@davemloft.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn,
konszert@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED
Date: Sat, 10 Aug 2013 01:30:09 +0530 [thread overview]
Message-ID: <52054A49.6000008@gmail.com> (raw)
In-Reply-To: <52054527.8080907@cogentembedded.com>
On Saturday 10 August 2013 01:08 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/09/2013 10:25 PM, Kumar Gaurav wrote:
>
>> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
>> of more than 80 chars on single line by sliting the line in two.
>
> That's clearly a material for 2 separate patches.
>
>> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
>> ---
>> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/lantiq_etop.c
>> b/drivers/net/ethernet/lantiq_etop.c
>> index bfdb0686..04c3a82 100644
>> --- a/drivers/net/ethernet/lantiq_etop.c
>> +++ b/drivers/net/ethernet/lantiq_etop.c
> [...]
>> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
>> if (err)
>> goto err_netdev;
>>
>> - /* Set addr_assign_type here, ltq_etop_set_mac_address would
>> reset it. */
>> + /* Set addr_assign_type here,
>> + *ltq_etop_set_mac_address would reset it.
>
> You forgot space after * here.
>
> WBR, Sergei
>
Okay i'll be sending them in separate and correcting a space issue as told.
thanks
Regards
Kumar Gaurav
prev parent reply other threads:[~2013-08-09 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:25 [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED Kumar Gaurav
2013-08-09 18:31 ` Kumar Gaurav
2013-08-09 19:38 ` Sergei Shtylyov
2013-08-09 20:00 ` Kumar Gaurav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52054A49.6000008@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=konszert@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).