From: Claudiu Manoil <claudiu.manoil@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <bhutchings@solarflare.com>,
Lutz Jaenicke <ljaenicke@innominate.com>
Subject: Re: [PATCH][net-next v1] gianfar: Add flow control support
Date: Mon, 12 Aug 2013 10:09:16 +0300 [thread overview]
Message-ID: <52088A1C.6010904@freescale.com> (raw)
In-Reply-To: <CAOMZO5CG3L3Jhjki-V7-jc+jBqRca_TTz_3e7=DP_1Zn8apZXQ@mail.gmail.com>
Right, thanks.
___
Claudiu
On 8/9/2013 8:36 PM, Fabio Estevam wrote:
> On Fri, Aug 9, 2013 at 2:19 PM, Claudiu Manoil
> <claudiu.manoil@freescale.com> wrote:
>
>> +static int gfar_spauseparam(struct net_device *dev,
>> + struct ethtool_pauseparam *epause)
>> +{
>> + struct gfar_private *priv = netdev_priv(dev);
>> + struct phy_device *phydev = priv->phydev;
>> + struct gfar __iomem *regs = priv->gfargrp[0].regs;
>> + u32 oldadv, newadv;
>> + int err = 0;
>
> You could drop this 'err' variable, no?
>
> ...
>
>> +
>> + return err;
>
> Then just 'return 0' here.
>
next prev parent reply other threads:[~2013-08-12 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 10:24 [PATCH 1/2][net-next] gianfar: Fix pause frame handling for half duplex links Claudiu Manoil
2013-08-07 10:24 ` [PATCH 2/2][net-next] gianfar: Add ethtool -A support for pause frame Claudiu Manoil
2013-08-07 19:12 ` Ben Hutchings
2013-08-08 17:10 ` Claudiu Manoil
2013-08-08 18:45 ` Ben Hutchings
2013-08-09 8:26 ` Lutz Jaenicke
2013-08-09 8:26 ` [PATCH] gianfar: implement flow control handling Lutz Jaenicke
2013-08-09 17:19 ` [PATCH][net-next v1] gianfar: Add flow control support Claudiu Manoil
2013-08-09 17:36 ` Fabio Estevam
2013-08-12 7:09 ` Claudiu Manoil [this message]
2013-08-09 19:09 ` Joe Perches
2013-08-12 7:08 ` Claudiu Manoil
2013-08-12 10:53 ` [PATCH][net-next v2] " Claudiu Manoil
2013-08-13 22:29 ` David Miller
2013-08-09 8:26 ` [PATCH] gianfar: add support for LFC (Lossless Flow Control) Lutz Jaenicke
2013-08-09 8:39 ` Joe Perches
2013-08-09 10:12 ` [PATCH 2/2][net-next] gianfar: Add ethtool -A support for pause frame Claudiu Manoil
2013-08-09 10:15 ` Lutz Jaenicke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52088A1C.6010904@freescale.com \
--to=claudiu.manoil@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=ljaenicke@innominate.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).